psp-8784 do not display cancel modal unless changes have been made to… #4183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devinleighsmith
force-pushed
the
psp-8784
branch
from
1cd2c79
to
f5e171c
Compare
|
✅ No secrets were detected in the code. |
|
✅ No secrets were detected in the code. |
eddherrera
reviewed
Jul 12, 2024
| isDisabled: false, | ||
| }, | ||
| consultationStatusType: { | ||
| id: 'UNKNOWN', |
There was a problem hiding this comment.
NIT: would be nice to use a generated codetype From the models backend project. (There has been many codetypes changes around lately.)
OR the value from getByType(API.CONSULTATION_TYPES) where id === [generatedCodeType].UNKNOWN
There was a problem hiding this comment.
I agree, I think making improvements to that is outside the scope of this bug for now, since I'm just moving some existing code around.
eddherrera
approved these changes
Jul 12, 2024
|
✅ No secrets were detected in the code. |
|
✅ No secrets were detected in the code. |
This was referenced Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… lease screen.