psp-8871 | Fixed Period totals not being calculated #4203
Conversation
…e payment to a class. Fixed issue with totals not beign calculated.
| @@ -1,274 +1,5 @@ | |||
| // Vitest Snapshot v1, https://vitest.dev/guide/snapshot.html | |||
|
|
|||
| exports[`PaymentsView component > renders as expected 1`] = ` | |||
There was a problem hiding this comment.
I've compared with Dev and I see no actual difference in the rendering. I will check with Sue once this is merged to confirm that nothing else has changed
| @@ -208,8 +208,36 @@ export class FormLeasePayment { | |||
| } | |||
| } | |||
|
|
|||
| export class FormLeasePeriodWithCategory extends FormLeasePeriod { | |||
| category: ApiGen_CodeTypes_LeasePaymentCategoryTypes; | |||
| export class LeasePeriodByCategoryProjection { | |||
There was a problem hiding this comment.
This class now encapsulates the data required to render the Payments by category when variable
| const variablePaymentData: LeasePeriodByCategoryProjection[] = [ | ||
| new LeasePeriodByCategoryProjection(period, ApiGen_CodeTypes_LeasePaymentCategoryTypes.BASE), | ||
| new LeasePeriodByCategoryProjection(period, ApiGen_CodeTypes_LeasePaymentCategoryTypes.ADDL), | ||
| new LeasePeriodByCategoryProjection(period, ApiGen_CodeTypes_LeasePaymentCategoryTypes.VBL), |
There was a problem hiding this comment.
Logic moved to the constructor of the class.
|
✅ No secrets were detected in the code. |
1 similar comment
|
✅ No secrets were detected in the code. |
| function renderActualTotal({ row: { original } }: CellProps<FormLeasePeriodWithCategory, string>) { | ||
| const total = formatMoney( | ||
| (original.payments ?? []) | ||
| .filter(p => p.leasePaymentCategoryTypeCode?.id === original.category) |
There was a problem hiding this comment.
This is where the actual bug was. This function was used for calculating the totals for the top table (period) and the category split. Because the top table did not have a category it did not add any of the payments.
|
✅ No secrets were detected in the code. |
|
✅ No secrets were detected in the code. |
|
✅ No secrets were detected in the code. |
Note: Most of the changes correspond to moving sections of code to different files. I've flagged the relevant pieces of code that are new