PSP-8746 | GST is modifiable for periods #4227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ No secrets were detected in the code. |
1 similar comment
|
✅ No secrets were detected in the code. |
|
✅ No secrets were detected in the code. |
|
✅ No secrets were detected in the code. |
asanchezr
reviewed
Jul 26, 2024
Comment on lines
79
to
83
| if (values === true) { | ||
| const gstDecimal = gstConstant !== undefined ? parseFloat(gstConstant.value) : undefined; | ||
| const calculated = round((formikState.values.paymentAmount as number) * (gstDecimal / 100)); | ||
| formikState.setFieldValue('gstAmount', calculated); | ||
| } else { |
There was a problem hiding this comment.
There is a code path here where gstDecimal is undefined (when the GST constant is not defined).
I'm not sure what would be the result of line 81 would be in this case; ie: calculated = round(... * (undefined/100))
Would it make sense to put a check here for that case?
There was a problem hiding this comment.
fair point. I added a better default value
asanchezr
reviewed
Jul 26, 2024
Comment on lines
36
to
40
| if (values === true) { | ||
| const gstDecimal = gstConstant !== undefined ? parseFloat(gstConstant.value) : undefined; | ||
| const calculated = round( | ||
| (getIn(formikProps.values, paymentAmountField) as number) * (gstDecimal / 100), | ||
| ); |
There was a problem hiding this comment.
same comment here re: gstDecimal being undefined
There was a problem hiding this comment.
same as above
asanchezr
approved these changes
Jul 26, 2024
|
✅ No secrets were detected in the code. |
This was referenced Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.