Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PSP-8879/PSP-7696 : Lease compensation requisition #4266

Merged
merged 15 commits into from
Aug 23, 2024

Conversation

eddherrera
Copy link
Collaborator

@eddherrera eddherrera commented Aug 15, 2024

@eddherrera eddherrera added the enhancement New feature or request label Aug 15, 2024
@eddherrera eddherrera self-assigned this Aug 15, 2024
# Conflicts:
#	source/frontend/src/features/mapSideBar/shared/detail/PropertyFileContainer.tsx
Copy link
Contributor

✅ No secrets were detected in the code.

@devinleighsmith
Copy link
Collaborator

Please merge and resolve conflicts - can't test locally now due to database issues with latest schema.

# Conflicts:
#	source/backend/tests/unit/api/Services/CompensationRequisitionServiceTest.cs
Copy link
Contributor

✅ No secrets were detected in the code.

@devinleighsmith
Copy link
Collaborator

ACcording to the mockup, the title should be "Compensation Requisition (Payable)"

@devinleighsmith
Copy link
Collaborator

Also "Add Requisition" instead of Add a Requisition"

@devinleighsmith
Copy link
Collaborator

The "Final date" doesn't appear to be set properly when I set a compensation to Final.

@devinleighsmith
Copy link
Collaborator

If I delete a lease comp req while the comp req is open, the deleted comp req remains open after deletion.

@devinleighsmith
Copy link
Collaborator

When I leave the compensation tab while viewing a compensation the viewed compensation does not close.

@devinleighsmith
Copy link
Collaborator

The following fields don't seem to be populating correctly from the file's project:

Business function:
Work activity:
Cost type:

Copy link
Collaborator

@devinleighsmith devinleighsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments, seems close.

@eddherrera
Copy link
Collaborator Author

ACcording to the mockup, the title should be "Compensation Requisition (Payable)"

This requirement changed and the mockup is no longer valid.

@devinleighsmith
Copy link
Collaborator

ACcording to the mockup, the title should be "Compensation Requisition (Payable)"

This requirement changed and the mockup is no longer valid.

You'll need a note or something or the mockup to be updated, or Praveen will say the same thing.

Copy link
Contributor

✅ No secrets were detected in the code.

Copy link
Contributor

✅ No secrets were detected in the code.

Copy link
Contributor

✅ No secrets were detected in the code.

Copy link
Contributor

✅ No secrets were detected in the code.

Copy link
Contributor

✅ No secrets were detected in the code.

@eddherrera
Copy link
Collaborator Author

ACcording to the mockup, the title should be "Compensation Requisition (Payable)"

This requirement changed and the mockup is no longer valid.

You'll need a note or something or the mockup to be updated, or Praveen will say the same thing.

Ana and Julian updated the mockups.

@eddherrera eddherrera merged commit 0ed070a into bcgov:dev Aug 23, 2024
7 checks passed
@eddherrera eddherrera deleted the psp-8879 branch August 23, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants