-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PSP-8879/PSP-7696 : Lease compensation requisition #4266
Conversation
# Conflicts: # source/frontend/src/features/mapSideBar/property/tabs/propertyAssociations/LeaseAssociationContent.tsx
# Conflicts: # source/frontend/src/features/mapSideBar/shared/detail/PropertyFileContainer.tsx
✅ No secrets were detected in the code. |
Please merge and resolve conflicts - can't test locally now due to database issues with latest schema. |
# Conflicts: # source/backend/tests/unit/api/Services/CompensationRequisitionServiceTest.cs
✅ No secrets were detected in the code. |
ACcording to the mockup, the title should be "Compensation Requisition (Payable)" |
Also "Add Requisition" instead of Add a Requisition" |
The "Final date" doesn't appear to be set properly when I set a compensation to Final. |
If I delete a lease comp req while the comp req is open, the deleted comp req remains open after deletion. |
When I leave the compensation tab while viewing a compensation the viewed compensation does not close. |
The following fields don't seem to be populating correctly from the file's project: Business function: |
...e/backend/api/Areas/CompensationRequisition/Controllers/CompensationRequisitionController.cs
Outdated
Show resolved
Hide resolved
source/frontend/src/features/mapSideBar/acquisition/models/PayeeOptionModel.ts
Show resolved
Hide resolved
...ntend/src/features/mapSideBar/compensation/detail/CompensationRequisitionDetailContainer.tsx
Show resolved
Hide resolved
...e/frontend/src/features/mapSideBar/compensation/detail/CompensationRequisitionDetailView.tsx
Outdated
Show resolved
Hide resolved
...e/frontend/src/features/mapSideBar/compensation/detail/CompensationRequisitionDetailView.tsx
Show resolved
Hide resolved
source/frontend/src/features/mapSideBar/compensation/list/CompensationListContainer.tsx
Outdated
Show resolved
Hide resolved
source/frontend/src/features/mapSideBar/compensation/list/CompensationListContainer.tsx
Outdated
Show resolved
Hide resolved
source/frontend/src/features/mapSideBar/compensation/models/FinancialActivityFormModel.ts
Show resolved
Hide resolved
...ntend/src/features/mapSideBar/compensation/update/UpdateCompensationRequisitionContainer.tsx
Show resolved
Hide resolved
source/frontend/src/features/mapSideBar/lease/detail/LeaseTabsContainer.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comments, seems close.
This requirement changed and the mockup is no longer valid. |
You'll need a note or something or the mockup to be updated, or Praveen will say the same thing. |
✅ No secrets were detected in the code. |
✅ No secrets were detected in the code. |
✅ No secrets were detected in the code. |
✅ No secrets were detected in the code. |
✅ No secrets were detected in the code. |
Ana and Julian updated the mockups. |
PSP-8879
PSP-7696