PSP-8977 : Add Total Allowable Compensation to Compensation Section #4280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
eddherrera
commented
Aug 23, 2024
eddherrera
commented
|
✅ No secrets were detected in the code. |
|
✅ No secrets were detected in the code. |
| return query.AsNoTracking().ToArray(); | ||
| } | ||
|
|
||
| public IEnumerable<PimsCompReqFinancial> GetAllByLeaseFileId(long leaseFileId, bool? finalOnly) | ||
| { | ||
| this._user.ThrowIfNotAllAuthorized(Security.Permissions.CompensationRequisitionView); |
There was a problem hiding this comment.
nit: can you just use ThrowIfNotAuthorized here (there is only one permission).
| case ApiGen_CodeTypes_FileTypes.Lease: | ||
| { | ||
| const updatedLease = file as ApiGen_Concepts_Lease; | ||
| file.totalAllowableCompensation = totalAllowableCompensation; |
There was a problem hiding this comment.
I think this works because updatedLease and file point to the same reference, but probably would be clearer to say updatedLease.totalAllowableCompensation
devinleighsmith
approved these changes
Aug 26, 2024
FuriousLlama
approved these changes
Aug 28, 2024
|
✅ No secrets were detected in the code. |
|
✅ No secrets were detected in the code. |
|
✅ No secrets were detected in the code. |
|
✅ No secrets were detected in the code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.