Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PSP-8988 Add Crown Details tab for any property that has Tantalis record #4307

Merged
merged 5 commits into from
Sep 9, 2024

Conversation

asanchezr
Copy link
Collaborator

video.mp4

@asanchezr asanchezr added the enhancement New feature or request label Sep 7, 2024
@asanchezr asanchezr self-assigned this Sep 7, 2024
Copy link
Contributor

github-actions bot commented Sep 7, 2024

✅ No secrets were detected in the code.

{crownFeature?.properties?.TENURE_DOCUMENT ?? ''}
</SectionField>
<SectionField label="Tenure expiry">
{prettyFormatDate(crownFeature?.properties?.TENURE_EXPIRY)}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appears to be changing the date based on the assumption that the date occurs at 00:00:00 UTC - I'm guessing we want to keep the date as is:

Ie: "2025-08-22Z" from the layer is displayed as Aug 21, 2025

Copy link
Contributor

github-actions bot commented Sep 9, 2024

✅ No secrets were detected in the code.

Copy link
Contributor

github-actions bot commented Sep 9, 2024

✅ No secrets were detected in the code.

@asanchezr asanchezr merged commit 6f1b250 into bcgov:dev Sep 9, 2024
7 checks passed
@asanchezr asanchezr deleted the psp-8988-crown-details branch September 11, 2024 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants