Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PSP-8880: Fixes based on last PR comments #4308

Merged
merged 5 commits into from
Sep 9, 2024
Merged

PSP-8880: Fixes based on last PR comments #4308

merged 5 commits into from
Sep 9, 2024

Conversation

stairaku
Copy link
Collaborator

@stairaku stairaku commented Sep 9, 2024

Replacing PR 4263:

  • Changes on LeaseStakeholderTypeModel.cs from BaseConcurrentModel to CodeTypeModel
  • Deleting console logs
  • Changes on LeasePages/stakeholders/columns to improve readiness
  • Improve Lease Tabs implementation
  • Fixing merge conflicts

@stairaku stairaku added enhancement New feature or request 5.5 labels Sep 9, 2024
@stairaku stairaku self-assigned this Sep 9, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 9, 2024

✅ No secrets were detected in the code.

@asanchezr asanchezr merged commit 976e3f1 into bcgov:dev Sep 9, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asanchezr asanchezr asanchezr approved these changes

@devinleighsmith devinleighsmith Awaiting requested review from devinleighsmith

Assignees

@stairaku stairaku

Labels
5.5 enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stairaku @asanchezr