Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disbursement Receipt Process - Expectations on Fail #4155

Open
7 tasks done
CarlyCotton opened this issue Dec 19, 2024 · 1 comment
Open
7 tasks done

Disbursement Receipt Process - Expectations on Fail #4155

CarlyCotton opened this issue Dec 19, 2024 · 1 comment
Assignees

Comments

@CarlyCotton
Copy link
Collaborator

CarlyCotton commented Dec 19, 2024

User Story
SIMS processes a daily disbursement file which contains federal and provincial funds disbursed for FT and PT applications. When we recognize disbursement records that relate to SIMS disbursements, we need to process those as normal. If we receive no records or only non-SIMS disbursements, we still want to send an email as part of this disbursement receipt scheduler to indicate we successfully received and processed a file but did not have any SIMS disbursements. If this process fails, we do NOT want any email sent.

Acceptance Criteria

  • If import successful with no SIMS records, email should still be sent.
  • If import successful with no SIMS records, email should contain a 0 record CSV (Batch run can be blank):

image.png

  • If disbursement process doesn't have a file to run: FAIL (can manually retry with existing functionality, but will allow us to be notified and retry at a later time)
  • Update scheduler for disbursement to run only M-F.

Additional Context
Successful CSV file/email sent:
image.png
0 records found, no csv file or email sent:
image.png
Current process result with no file found:
image.png

** Technical **

  • When there is no CSV record, build a blank record file as stated in the business AC. disbursement-receipt.processing.service.ts
  • When there is no file to process, log the error using processSummary error and the framework will automatically retry.
  • E2E Tests
  • E2E Test for an empty record
  • E2E Test for no file
@CarlyCotton CarlyCotton added the Business Items under Business Consideration label Dec 19, 2024
@CarlyCotton CarlyCotton self-assigned this Dec 31, 2024
@CarlyCotton CarlyCotton added Dev & Architecture Development and Architecture and removed Business Items under Business Consideration labels Dec 31, 2024
@dheepak-aot
Copy link
Collaborator

@CarlyCotton The current retry interval is 3 minutes for disbursement receipts scheduler. (It retries 3 times). Let us know if the retry interval or the number of retry per failure needs to be updated.

@dheepak-aot dheepak-aot removed the Dev & Architecture Development and Architecture label Dec 31, 2024
@guru-aot guru-aot self-assigned this Jan 8, 2025
guru-aot added a commit that referenced this issue Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants