Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NOA Eligible to Receive - Double Counting BC Grants #4226

Closed
3 tasks
CarlyCotton opened this issue Jan 10, 2025 · 0 comments
Closed
3 tasks

NOA Eligible to Receive - Double Counting BC Grants #4226

CarlyCotton opened this issue Jan 10, 2025 · 0 comments
Assignees
@bidyashish @CarlyCotton
Labels
Student Student Features
Milestone
Post Part-Time Pr...

Comments

@CarlyCotton
Copy link
Collaborator

CarlyCotton commented Jan 10, 2025 •
edited by andrewsignori-aot
Loading

User Story
As a student, when I view my NOA the total eligible to receive should match the total of the individual awards.

Acceptance Criteria

  • Update the Eligible to Receive amount to not include BC Total Grant from the disbursement_values so it's not being double counted.
  • Check post ecert calculation. This is when the BC Total grant is added to the table.

Additional Context
Currently, we are double counting BC Grants, this is only affecting the total display and not impacting anything downstream like ecerts.
image.png

Technical

  • If E2E tests are in place please adjust it to cover this scenario, including the "BC Total Grant" in the data setup and asserting the expected value.
@CarlyCotton CarlyCotton added Business Items under Business Consideration Student Student Features labels Jan 10, 2025
@CarlyCotton CarlyCotton self-assigned this Jan 14, 2025
@Joshua-Lakusta Joshua-Lakusta added Dev & Architecture Development and Architecture and removed Business Items under Business Consideration labels Jan 14, 2025
@andrewsignori-aot andrewsignori-aot removed the Dev & Architecture Development and Architecture label Jan 14, 2025
@bidyashish bidyashish self-assigned this Jan 14, 2025
github-merge-queue bot pushed a commit that referenced this issue Jan 15, 2025
@bidyashish
#4226 - NOA Eligible to Receive - Double Counting BC Grants (#4238)
7fdd7c6 
**Acceptance Criteria**
- [x] Update the Eligible to Receive amount to not include **BC Total
Grant** from the `disbursement_values` so it's not being double counted.
- [x] Check post ecert calculation. This is when the BC Total grant is
added to the table.


**Technical**
- [x] If E2E tests are in place please adjust it to cover this scenario,
including the "BC Total Grant" in the data setup and asserting the
expected value.

E2E test data is taken from sample data.
bidyashish added a commit that referenced this issue Jan 15, 2025
@bidyashish
#4226 - NOA Eligible to Receive - Double Counting BC Grants (#4238)
12667be 
**Acceptance Criteria**
- [x] Update the Eligible to Receive amount to not include **BC Total
Grant** from the `disbursement_values` so it's not being double counted.
- [x] Check post ecert calculation. This is when the BC Total grant is
added to the table.


**Technical**
- [x] If E2E tests are in place please adjust it to cover this scenario,
including the "BC Total Grant" in the data setup and asserting the
expected value.

E2E test data is taken from sample data.
bidyashish added a commit that referenced this issue Jan 15, 2025
@bidyashish
#4226 - NOA Eligible to Receive - Double Counting BC Grants (#4238) (#…
0bb4faf 
…4242)

**Acceptance Criteria**
- [x] Update the Eligible to Receive amount to not include **BC Total
Grant** from the `disbursement_values` so it's not being double counted.
- [x] Check post ecert calculation. This is when the BC Total grant is
added to the table.


**Technical**
- [x] If E2E tests are in place please adjust it to cover this scenario,
including the "BC Total Grant" in the data setup and asserting the
expected value.

E2E test data is taken from sample data.
@bidyashish bidyashish mentioned this issue Jan 16, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bidyashish bidyashish

@CarlyCotton CarlyCotton

Labels
Student Student Features
Projects
None yet
Milestone
Post Part-Time Primera Importante Mucho
Development

No branches or pull requests
5 participants
@bidyashish @ninosamson @andrewsignori-aot @Joshua-Lakusta @CarlyCotton