Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3984 - BUG: Ministry - Change Request Form submitted by Student not displaying Year #4250

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

andrewsignori-aot
Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot commented Jan 15, 2025

  • Added programYear as a persistent value for all the appeals forms.
  • Added programYear to the "Appeals - Student Disability Information" to ensure all the forms share the same program year hidden field that can be potentially used to adjust the forms to different program years.

Note: we got the confirmation from the business (in the ticket comments) that there is no need to apply a fix to production data at this moment.

@andrewsignori-aot andrewsignori-aot added Student Student Features Ministry Ministry Features Form.io Form IO definitions changed. labels Jan 15, 2025
@andrewsignori-aot andrewsignori-aot self-assigned this Jan 15, 2025
@andrewsignori-aot andrewsignori-aot changed the title #3984 - Student: FT: Former Youth in Care Question Update #3984 - BUG: Ministry - Change Request Form submitted by Student not displaying Year Jan 15, 2025
@andrewsignori-aot andrewsignori-aot added the Bug Something isn't working label Jan 15, 2025
Copy link

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 22.52% ( 3864 / 17157 )
Methods: 10.33% ( 224 / 2169 )
Lines: 25.93% ( 3336 / 12864 )
Branches: 14.31% ( 304 / 2124 )

Copy link

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 65.59% ( 589 / 898 )
Methods: 59.63% ( 65 / 109 )
Lines: 68.72% ( 468 / 681 )
Branches: 51.85% ( 56 / 108 )

Copy link

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 86.14% ( 1249 / 1450 )
Methods: 82.42% ( 136 / 165 )
Lines: 88.51% ( 1032 / 1166 )
Branches: 68.07% ( 81 / 119 )

Copy link

E2E SIMS API Coverage Report

Totals Coverage
Statements: 67.77% ( 5994 / 8844 )
Methods: 65.57% ( 739 / 1127 )
Lines: 71.63% ( 4696 / 6556 )
Branches: 48.15% ( 559 / 1161 )

@andrewsignori-aot andrewsignori-aot marked this pull request as ready for review January 16, 2025 00:10
@dheepak-aot dheepak-aot self-requested a review January 16, 2025 16:56
Copy link
Collaborator

@dheepak-aot dheepak-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job!. Looks good.

Copy link
Collaborator

@guru-aot guru-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work @andrewsignori-aot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Form.io Form IO definitions changed. Ministry Ministry Features Student Student Features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants