Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#4262 - Fix part-time family size variables DMN #4267

Merged
merged 2 commits into from
Jan 21, 2025
Merged

#4262 - Fix part-time family size variables DMN #4267

merged 2 commits into from
Jan 21, 2025

Conversation

dheepak-aot
Copy link
Collaborator

@dheepak-aot dheepak-aot commented Jan 20, 2025 •
edited
Loading

Fix part-time family size variables DMN

  • Updated the PT DMN for family size to match family size of 7. Before the update the match was missing for family size = 7.
  • Updated the modeler platform version and exporter version for DMN.
  • Added E2E tests(Picked one of the award eligibility to satisfy all possible conditions based on family size).

@dheepak-aot dheepak-aot added E2E/Unit tests Camunda Worflow Involves camunda workflow changes labels Jan 20, 2025
@dheepak-aot dheepak-aot self-assigned this Jan 20, 2025
@dheepak-aot dheepak-aot marked this pull request as ready for review January 21, 2025 01:06
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions GitHub Actions
Copy link

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 22.51% ( 3864 / 17164 )
Methods: 10.32% ( 224 / 2170 )
Lines: 25.92% ( 3336 / 12870 )
Branches: 14.31% ( 304 / 2124 )

@github-actions GitHub Actions
Copy link

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 65.59% ( 589 / 898 )
Methods: 59.63% ( 65 / 109 )
Lines: 68.72% ( 468 / 681 )
Branches: 51.85% ( 56 / 108 )

@github-actions GitHub Actions
Copy link

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 86.14% ( 1249 / 1450 )
Methods: 82.42% ( 136 / 165 )
Lines: 88.51% ( 1032 / 1166 )
Branches: 68.07% ( 81 / 119 )

@github-actions GitHub Actions
Copy link

E2E SIMS API Coverage Report

Totals Coverage
Statements: 68.09% ( 6022 / 8844 )
Methods: 65.84% ( 742 / 1127 )
Lines: 71.92% ( 4715 / 6556 )
Branches: 48.66% ( 565 / 1161 )

andrewsignori-aot
andrewsignori-aot approved these changes Jan 21, 2025
View reviewed changes
Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, looks good 👍

guru-aot
guru-aot approved these changes Jan 21, 2025
View reviewed changes
Copy link
Collaborator

@guru-aot guru-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work @dheepak-aot

@dheepak-aot dheepak-aot added this pull request to the merge queue Jan 21, 2025
Merged via the queue into main with commit e234f0b Jan 21, 2025
21 checks passed
@dheepak-aot dheepak-aot deleted the bug/#4262-fix-family-size-dmn branch January 27, 2025 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewsignori-aot andrewsignori-aot andrewsignori-aot approved these changes

@guru-aot guru-aot guru-aot approved these changes

Assignees

@dheepak-aot dheepak-aot

Labels
Camunda Worflow Involves camunda workflow changes E2E/Unit tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dheepak-aot @andrewsignori-aot @guru-aot