#3315 - Content: Ministry: Student Requests Exceptions #4274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
andrepestana-aot
commented
Jan 21, 2025
•
andrepestana-aot
commented
- Revised title and subtitle;
- Expanded "Name" column into "Given names" and "Last name";
andrepestana-aot
added
Ministry
dheepak-aot
reviewed
Jan 21, 2025
| @@ -38,6 +38,7 @@ export interface ApplicationExceptionSummaryAPIOutDTO { | |||
| applicationId: number; | |||
| studentId: number; | |||
| submittedDate: Date; | |||
| fullName: string; | |||
| givenNames: string; | |||
There was a problem hiding this comment.
given names is optional.
dheepak-aot
reviewed
Jan 21, 2025
| @@ -61,6 +61,7 @@ export class ApplicationExceptionSummaryAPIOutDTO { | |||
| applicationId: number; | |||
| studentId: number; | |||
| submittedDate: Date; | |||
| fullName: string; | |||
| givenNames: string; | |||
dheepak-aot
approved these changes
Jan 21, 2025
There was a problem hiding this comment.
Great job @andrepestana-aot. Left 2 minor comments. Please have a look
guru-aot
approved these changes
Jan 21, 2025
|
Backend Unit Tests Coverage Report
|
E2E Workflow Workers Coverage Report
|
E2E Queue Consumers Coverage Report
|
E2E SIMS API Coverage Report
|
andrepestana-aot
deleted the
3315_content_ministry_student_requests_exceptions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.