Fix person issuer name #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: wadeking98 <wkingnumber2@gmail.com>
Signed-off-by: wadeking98 <wkingnumber2@gmail.com>
wadeking98
force-pushed
the
fix-person-issuer-name
branch
from
f3ae24b to
a782b6e
Compare
|
@marcos-carretero, can you review this changes for the Person Credential? |
|
@dbigsby, you might be interested in reviewing this changes to re-align with what we had for Person credential |
Signed-off-by: wadeking98 <wkingnumber2@gmail.com>
5 tasks
| "digest": "EuBEK7v-Jq5bqW72CmB8jOzxRllFiW3u5KbhT6nMVzfg", | ||
| "issuer": "Service BC", | ||
| "issuer_description": "Service BC", | ||
| "issuer_url": "https://www2.gov.bc.ca/gov/content?id=87EEAD6D19974459950AA7FF7F60AD54", |
There was a problem hiding this comment.
This URL points to a web page about the physical BC Services Card plastic credential. It is likely ok for the short term. I'll check with IDIM and the team.
|
Is this ready to merge? It’s much better than what we have right now... |
marcos-carretero
approved these changes
Oct 10, 2023
swcurran
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the issuer name and links to be inline with IDIM