Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: temporarily re-introduce v4/search/autocomplete #748

Merged
merged 1 commit into from
Jun 7, 2023

Conversation

amanji
Copy link
Contributor

@amanji amanji commented Jun 7, 2023

This is a temporary re-introduction of v4/search/autocomplete to give time for end users to migrate off. The endpoint is marked as DEPRECATED and should be removed as soon as possible.

The v3 endpoint is not impacted (to confirm, it has been tested against OrgBook BC). All changes in this PR are isolated to the v4 endpoint (with some minor technical debt introduced).

Signed-off-by: Akiff Manji <akiff.manji@quartech.com>
@amanji amanji self-assigned this Jun 7, 2023
@amanji amanji linked an issue Jun 7, 2023 that may be closed by this pull request
@amanji amanji marked this pull request as ready for review June 7, 2023 00:15
@amanji amanji requested review from esune and WadeBarnes June 7, 2023 00:15
@esune esune merged commit dd2a7fb into bcgov:main Jun 7, 2023
@esune
Copy link
Member

esune commented Jun 7, 2023

@WadeBarnes leaving teh promotion of this new version to test/prod to you

@WadeBarnes
Copy link
Member

@amanji, @esune, The updates have been deployed to test. Please have a quick look and if all is ok, I'll deploy to prod tomorrow morning.

@amanji
Copy link
Contributor Author

amanji commented Jun 7, 2023

LGTM. The OrgBook Search UI is not returning anomalous results.

@amanji amanji linked an issue Jun 7, 2023 that may be closed by this pull request
@WadeBarnes
Copy link
Member

@amanji, @esune, The updates have been deployed to prod.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revert, reversion of v4 Autocomplete API Autocomplete usage producing unusable results
3 participants