Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore location of management commands #801

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Restore location of management commands #801

merged 1 commit into from
Dec 12, 2024

Conversation

ianco
Copy link
Contributor

@ianco ianco commented Dec 11, 2024

This puts the commands back where django can find them ...

Issue #800

Signed-off-by: Ian Costanzo <ian@anon-solutions.ca>
@ianco ianco requested review from swcurran and WadeBarnes December 11, 2024 22:20
@WadeBarnes WadeBarnes requested a review from amanji December 12, 2024 15:06
@WadeBarnes
Copy link
Member

@ianco, @amanji, Is this going to cause any issues with the refactoring that moved these files in the first place?

@ianco ianco merged commit 8f848c6 into bcgov:main Dec 12, 2024
1 check passed
@amanji
Copy link
Contributor

amanji commented Dec 12, 2024

I don't believe they are being used outside of Django's manage.py. The processing flow for incoming credentials in Aries VCR goes through a different function.

@ianco
Copy link
Contributor Author

ianco commented Dec 12, 2024

@ianco, @amanji, Is this going to cause any issues with the refactoring that moved these files in the first place?

That's a question for @amanji

I tested them once they were moved back and they are now working

@WadeBarnes
Copy link
Member

I don't believe they are being used outside of Django's manage.py. The processing flow for incoming credentials in Aries VCR goes through a different function.

Does that mean they got moved by mistake, and now they are back where they belong?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants