Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): patch for credo core and credo hooks #2370

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

bryce-mcmath
Copy link
Contributor

@bryce-mcmath bryce-mcmath commented Feb 5, 2025

These patches are required for proper behaviour after agent.shutdown() and consecutive agent.initialize(). Without these patch updates it is currently broken in this situation (after lockout for example)

Note: I removed the .js.map parts of the existing patches, as they already weren't working and are only used for source maps and make the patches harder to read - all source maps are used for is making code easier to read after it's been minified, which is more relevant for web development rather than mobile.

Relevant issues: #2226 and #2243

Signed-off-by: Bryce McMath <bryce.j.mcmath@gmail.com>
Copy link

sonarqubecloud bot commented Feb 5, 2025

Copy link
Contributor

@al-rosenthal al-rosenthal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ran this locally and was able to get my person credential after a lockout, well done!

@al-rosenthal al-rosenthal merged commit 46e14fb into main Feb 5, 2025
16 checks passed
@al-rosenthal al-rosenthal deleted the fix/patch-restarts-and-hooks branch February 5, 2025 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants