Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Struct options #13

Merged
merged 6 commits into from
Aug 24, 2017
Merged

Struct options #13

merged 6 commits into from
Aug 24, 2017

Conversation

ateucher
Copy link
Contributor

Adds the ability to specify a different file/folder structure than the default. Closes #10

@ateucher
Copy link
Contributor Author

@boshek or @stephhazlitt would either of you like to review? If not I'll just go ahead and merge...

@boshek
Copy link
Contributor

boshek commented Aug 24, 2017

Seems all good to me. The only thought I've had is to have canned values for dir_struct with recognizable names that specify a file structure. But I need think more and whether that actually makes this simpler or more complicated.

@ateucher
Copy link
Contributor Author

Can you give an example of what you mean? There is a default structure: c("R/","out/", "graphics/", "data/", "01_load.R", "02_clean.R", "03_analysis.R", "04_output.R", "internal.R", "run_all.R"), but I guess you are talking about something different?

@ateucher
Copy link
Contributor Author

Oh I know what you mean now! A set of pre-canned directory structures to choose from. Not a bad idea, but I think I'll merge this and we can think more about that.

@ateucher ateucher merged commit 513f41a into master Aug 24, 2017
@boshek boshek deleted the struct-options branch December 2, 2017 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants