25942 - added future effective state to entity states enum #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -4,6 +4,7 @@ export enum EntityStates { | |||
| AWAITING_REVIEW = 'AWAITING_REVIEW', | |||
| CHANGE_REQUESTED = 'CHANGE_REQUESTED', | |||
| DRAFT = 'DRAFT', | |||
| FUTURE_EFFECTIVE = 'FUTURE_EFFECTIVE', | |||
There was a problem hiding this comment.
Is this an actual state (from Legal API), or is it more of a pseudo-state (computed by you)? If the latter then see if you can extend the enum right in the BRD code.
There was a problem hiding this comment.
It's kinda more of the latter. Deal, going to leave this PR open for now and see if I can handle this there.
|
Closing this PR as it's not needed. Ref: bcgov/business-ui#67 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: /bcgov/entity#25942
Description of changes:
This is what things are going to look like in the table:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-filings-ui license (Apache 2.0).