19044 - Amalgamation unit tests #655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ketaki-deodhar
commented
Feb 14, 2024
| @@ -73,11 +73,11 @@ describe('Amalgamating Businesses - components and validity', () => { | |||
| }) | |||
|
|
|||
| it('computes havePrimaryBusiness correctly', () => { | |||
| // verify with no holding businesses | |||
| // verify with no primary businesses | |||
There was a problem hiding this comment.
Updated comment based on test. Same below.
ketaki-deodhar
commented
Feb 14, 2024
| import AmalgamatingBusinesses from '@/components/Amalgamation/AmalgamatingBusinesses.vue' | ||
| import { ExpandableHelp } from '@bcrs-shared-components/expandable-help' | ||
| import ResultingBusinessName from '@/components/Amalgamation/ResultingBusinessName.vue' | ||
| import BusinessTypeHelp from '@/components/Amalgamation/BusinessTypeHelp.vue' | ||
| import { AmalgamationTypes, FilingTypes } from '@bcrs-shared-components/enums' | ||
|
|
||
| // Test Case Data | ||
| const amalgamationRegularBusinessInfo = [ | ||
| const amalgamationBusinessInfo = [ |
There was a problem hiding this comment.
renamed as can be used for regular and short tests
ketaki-deodhar
commented
Feb 14, 2024
| @@ -28,18 +29,21 @@ const amalgamationRegularBusinessInfo = [ | |||
| } | |||
| ] | |||
|
|
|||
| for (const test of amalgamationRegularBusinessInfo) { | |||
| describe(`Amalgamation-Regular Review Confirm for a ${test.entityType}`, () => { | |||
| for (const test of amalgamationBusinessInfo) { | |||
There was a problem hiding this comment.
tests for Review and confirm are similar Regular vs Short. UIs are different for Staff vs regular user so added test at line 133
ketaki-deodhar
commented
Feb 14, 2024
| @@ -167,3 +168,57 @@ describe('People And Roles component', () => { | |||
| resetStore() | |||
| }) | |||
| }) | |||
|
|
|||
There was a problem hiding this comment.
Added a few tests for Short amalgamation (it is a bit of a different case than other filings)
ketaki-deodhar
requested review from
severinbeauvais,
jamespaologarcia and
PaulGarewal
For Short form, Share structure is not a step and is only shown in Review and Confirm step as read only. |
Oh, right. Please remove that comment. Thanks! |
severinbeauvais
approved these changes
Feb 14, 2024
JazzarKarim
pushed a commit
to JazzarKarim/business-create-ui
that referenced
this pull request
Feb 23, 2024
* 19044 - unit tests for Short amalgmation resources * 19044 - clean up * 19044 - add comment * 19044 - remove comment * 19044 - remove comment * 19044 - update package version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: /bcgov/entity#19044
Description of changes:
Added unit tests in:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).