Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

17347 - Add in appointmentDate for co-op corrections. #537

Merged
merged 1 commit into from
Oct 19, 2023
Merged

17347 - Add in appointmentDate for co-op corrections. #537

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "business-edit-ui",
"version": "4.7.3",
"version": "4.7.4",
"private": true,
"appName": "Edit UI",
"sbcName": "SBC Common Components",
Expand Down
5 changes: 4 additions & 1 deletion src/components/common/PeopleAndRoles/OrgPerson.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -494,6 +494,7 @@ export default class OrgPerson extends Mixins(CommonMixin, OrgPersonMixin) {
@Getter(useStore) getResource!: ResourceIF
@Getter(useStore) isAlterationFiling!: boolean
@Getter(useStore) isBenBcCccUlcCorrectionFiling!: boolean
@Getter(useStore) isCoopCorrectionFiling!: boolean
@Getter(useStore) isFirmCorrectionFiling!: boolean
@Getter(useStore) isFirm!: boolean
@Getter(useStore) isFirmChangeFiling!: boolean
Expand Down Expand Up @@ -851,7 +852,9 @@ export default class OrgPerson extends Mixins(CommonMixin, OrgPersonMixin) {
}
person.deliveryAddress = { ...this.inProgressDeliveryAddress }
}
if (this.isBenBcCccUlcCorrectionFiling) {
// Note: For corrections if the appointmentDate isn't included - you may run into some issues where adding a new
// director as it wont show up in the parties or directors call.
if (this.isBenBcCccUlcCorrectionFiling || this.isCoopCorrectionFiling) {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could change this to this.isCorrection && !this.isFirm

not sure if that's possible

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's possible but please don't use negative logic here -- we want to INCLUDE the desired types, not EXCLUDE certain types as this will fail when we add other types.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably best to just leave it how it is I think

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed.

person.roles = this.setPersonRoles(this.orgPerson)
} else {
person.roles = this.orgPerson.roles
Expand Down
Loading