Skip to content

Commit

Permalink
22399 Added unit tests (#686)
Browse files Browse the repository at this point in the history
- app version = 7.3.17
- italicized latest review comment in Todo List
- italicized latest review comment in Filing History List
- changed REJECTED to orange colour
- added unit tests

Co-authored-by: Severin Beauvais <severin.beauvais@gov.bc.ca>
  • Loading branch information
severinbeauvais and Severin Beauvais authored Jul 24, 2024
1 parent 80576c7 commit 2379af6
Show file tree
Hide file tree
Showing 5 changed files with 538 additions and 7 deletions.
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "business-filings-ui",
"version": "7.3.16",
"version": "7.3.17",
"private": true,
"appName": "Filings UI",
"sbcName": "SBC Common Components",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
<p class="mt-0">
This {{ filing.displayName }} is rejected for the following reasons:
</p>
<p>
<p class="font-italic">
{{ filing.latestReviewComment || '[undefined staff rejection message]' }}
</p>
<p>
Expand Down
6 changes: 3 additions & 3 deletions src/components/Dashboard/TodoList.vue
Original file line number Diff line number Diff line change
Expand Up @@ -260,7 +260,7 @@
v-else-if="EnumUtilities.isStatusChangeRequested(item)"
class="todo-subtitle pt-1"
>
<span>CHANGE REQUESTED</span>
<span class="orange--text text--darken-2">CHANGE REQUESTED</span>
<span class="vert-pipe" />
<span>PAID (filed by {{ item.submitter }} on <DateTooltip :date="item.submittedDate" />)</span>
</div>
Expand Down Expand Up @@ -609,8 +609,8 @@
<p class="list-item__subtitle">
This {{ item.title }} is paid but requires you to make the following changes:
</p>
<p class="list-item__subtitle">
{{ item.comment || '[undefined staff change request message]' }}
<p class="list-item__subtitle font-italic">
{{ item.latestReviewComment || '[undefined staff change request message]' }}
</p>
</div>
</template>
Expand Down
Loading

0 comments on commit 2379af6

Please sign in to comment.