Skip to content

Commit

Permalink
updated Continuation Application UI
Browse files Browse the repository at this point in the history
Signed-off-by: Qin <Arwen.Qin@gov.bc.ca>
  • Loading branch information
ArwenQin committed Jul 12, 2024
1 parent d8bf746 commit edcd60c
Show file tree
Hide file tree
Showing 5 changed files with 10 additions and 9 deletions.
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "business-filings-ui",
"version": "7.3.10",
"version": "7.3.11",
"private": true,
"appName": "Filings UI",
"sbcName": "SBC Common Components",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ import { Getter } from 'pinia-class'
import { ContactInfo } from '@/components/common'
import { ApiFilingIF } from '@/interfaces'
import { DateUtilities, EnumUtilities } from '@/services'
import { FilingNames } from '@bcrs-shared-components/enums'
import { useBusinessStore } from '@/stores'
@Component({
Expand All @@ -52,7 +53,7 @@ export default class FutureEffective extends Vue {
return {
subtitle: 'Future Effective Incorporation Date',
filingLabel: 'incorporation',
filingTitle: 'Incorporation Application'
filingTitle: FilingNames.INCORPORATION_APPLICATION
}
}
if (EnumUtilities.isTypeAlteration(this.filing)) {
Expand All @@ -66,14 +67,14 @@ export default class FutureEffective extends Vue {
return {
subtitle: 'Future Effective Voluntary Dissolution Date',
filingLabel: 'dissolution',
filingTitle: 'Voluntary Dissolution'
filingTitle: FilingNames.VOLUNTARY_DISSOLUTION
}
}
if (EnumUtilities.isTypeContinuationIn(this.filing)) {
return {
subtitle: 'Future Effective Incorporation Date',
filingLabel: 'continuation application',
filingTitle: 'Continuation Application'
filingLabel: 'incorporation',
filingTitle: FilingNames.CONTINUATION_IN_APPLICATION
}
}
return {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ export default class FutureEffectivePending extends Vue {
if (EnumUtilities.isTypeContinuationIn(this.filing)) {
return {
subtitle: 'Incorporation Pending',
filingLabel: 'continuation application'
filingLabel: 'incorporation'
}
}
return {
Expand Down
2 changes: 1 addition & 1 deletion src/components/common/NameRequestInfo.vue
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ export default class NameRequestInfo extends Mixins(DateMixin, EnumMixin, NameRe
case NrRequestActionCodes.NEW_BUSINESS: return 'New Business'
case NrRequestActionCodes.RESTORE: return 'Restoration Request'
case NrRequestActionCodes.AMALGAMATE: return 'Amalgamation'
case NrRequestActionCodes.MOVE: return 'Continuation Application'
case NrRequestActionCodes.MOVE: return 'Continuation In'
}
return '' // should never happen
}
Expand Down

0 comments on commit edcd60c

Please sign in to comment.