correction filing (part 1) #22
Conversation
- updated Correction filing page - updated Detail Comment to support maxLength prop and to use placeholder instead of label - updated Staff Payment component (with Priority and No Fee) - TODO: Summary Staff Payment - TODO: other filings (re: StaffPayment) - TODO: unit tests
severinbeauvais
force-pushed
the
2654
branch
from
74eb33a
to
603ec0e
Compare
| // inform parent of initial validity | ||
| this.emitValid(this.value) | ||
| } | ||
|
|
||
| /** | ||
| * Called when prop changes (ie, v-model is updated by parent). | ||
| * This method is debounced to prevent excessive validation. | ||
| */ | ||
| @Watch('value') | ||
| @Debounce(300) |
There was a problem hiding this comment.
I know this was not implemented in this PR, but this makes me think. Should we have implemented the Debounce decorator on all our listeners? Just a little bit of reading on the topic makes me think it is certainly not a bad thing when trying to optimize performance. No Action required here, just starting a conversation :)
There was a problem hiding this comment.
I implemented it here because it needed it (it validated a bunch of rules on every keystroke, which made system responsiveness noticeably slow).
I think we should debounce methods when needed, but I haven't found any other candidates. Do you have something in mind?
There was a problem hiding this comment.
No nothing specific, i just know that some of the watchers are triggered constantly and was just thinking ( theoretically ) this is a cool way of optimizing. It's just something i'll keep in mind going forward, if a watcher is a good candidate for Debouncing.
There was a problem hiding this comment.
Just a few comments/questions. I don't believe anything needs to be actioned at this point. There are some failing unit tests but as we discussed, this PR is to get the work in to clear dependencies for each other and we will resolve the unit tests / updates in a following PR. Approved!
|
SonarCloud Quality Gate failed.
|
* updated doc,dockerfile,dc + added jenkinsfile * documentation for importing oracle Signed-off-by: Kial Jinnah <kialj876@gmail.com>
* Implemented Unit testing and complete Filing Functionality * Code Clean up * Updated Auth Url for pinelines env * updated logic * Fixed test * Updated Unit testing
updated deploy scripts + readme
Issue #: /bcgov/entity#2654
Description of changes:
This is Part 1 of the Correction Filing task, which includes:
Part 2 will implement:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-filings-ui license (Apache 2.0).