21948 - Change Continuation Application #679
Conversation
Signed-off-by: Qin <Arwen.Qin@gov.bc.ca>
Signed-off-by: Qin <Arwen.Qin@gov.bc.ca>
Signed-off-by: Qin <Arwen.Qin@gov.bc.ca>
|
Filing UI after change: |
|
Temporary Url for review: https://business-filings-dev--pr-679-2vtz07q6.web.app |
src/components/Dashboard/FilingHistoryList/bodies/FutureEffectivePending.vue
Outdated
Show resolved
Hide resolved
src/components/Dashboard/FilingHistoryList/bodies/FutureEffective.vue
Outdated
Show resolved
Hide resolved
|
Arwen, please revert the change in NameRequestInfo.vue (per Andy), and then attach some screenshots of what the Future Effective and Future Effective Pending filings look like. Did you confirm that the default values are not being used? Thanks. |
Signed-off-by: Qin <Arwen.Qin@gov.bc.ca>
|
/gcbrun |
Hi Severin, I just updated the UIs per design of Andy, please see below. |
|
Future Effective Pending: |
|
Future Effective Pending after change: |
| @@ -52,7 +53,7 @@ export default class FutureEffective extends Vue { | |||
| return { | |||
| subtitle: 'Future Effective Incorporation Date', | |||
| filingLabel: 'incorporation', | |||
| filingTitle: 'Incorporation Application' | |||
| filingTitle: FilingNames.INCORPORATION_APPLICATION | |||
There was a problem hiding this comment.
Line 56, 70, 77: used enum FilingNames for filingTitle
Issue #: /bcgov/entity#21948
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-filings-ui license (Apache 2.0).