Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

16978 Add valid parties to CORRECTION_CP_SPECIAL_RESOLUTION #142

Merged
merged 6 commits into from
Aug 30, 2023

Conversation

ChrisGabel23
Copy link
Contributor

@ChrisGabel23 ChrisGabel23 commented Aug 23, 2023

Issue #: /bcgov/entity#16978

Description of changes:
The specific file to look at is schema_data.py, the rest is from the cherry-picked commit.

  • Added valid parties to CORRECTION_CP_SPECIAL_RESOLUTION.
  • Cherry-picked commit 46fe420

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-schemas license (Apache 2.0).

@leodube-aot leodube-aot changed the title Ticket16978 16978 Add valid parties to CORRECTION_CP_SPECIAL_RESOLUTION Aug 29, 2023
@leodube-aot leodube-aot marked this pull request as ready for review August 29, 2023 18:33
Copy link
Collaborator

@severinbeauvais severinbeauvais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't say I fully understand this, but it looks OK to me 😁

Copy link
Collaborator

@severinbeauvais severinbeauvais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this specific to special resolution corrections as per the ticket requirements?

@leodube-aot
Copy link
Collaborator

Is this specific to special resolution corrections as per the ticket requirements?

Yeah these are specific to special resolution corrections. It comes from task 2 in the ticket ("Update example business schema...") and is used for the new unit test.

@argush3 argush3 merged commit e21d9ae into bcgov:main Aug 30, 2023
2 checks passed
@ChrisGabel23 ChrisGabel23 deleted the ticket16978 branch September 6, 2023 19:55
JazzarKarim pushed a commit to JazzarKarim/business-schemas that referenced this pull request Jan 31, 2024
* added parties to CORRECTION_CP_SPECIAL_RESOLUTION

* added 2 more parties to CORRECTION_CP_SPECIAL_RES

* removed "partner" type

* editing party list

* Bump version to 2.18.11

* Cherry-pick 46fe420

---------

Co-authored-by: Leo Dube <leo.dube@aot-technologies.com>
Co-authored-by: Vysakh Menon <vysakh.menon@aot-technologies.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants