23562 (2 step continuation in filing) before and after approval of authorization documents #169
Conversation
…thorization documents
vysakh-menon-aot
requested review from
kialj876 and
thorwolpert
as code owners
vysakh-menon-aot
requested review from
argush3,
severinbeauvais and
ketaki-deodhar
| "properties": { | ||
| "isApproved": { |
There was a problem hiding this comment.
Setting this value to True will be handled from legal-api (before validating filing json)
There was a problem hiding this comment.
So the UI will need to read this from a draft and then save it upon filing?
There was a problem hiding this comment.
Nope. UI doesn't need to provide this at any stage. Even if UI provides it will be overwritten by legal-api based on the filing status
There was a problem hiding this comment.
Would it be better to just have a duplicate of the filing status here?
There was a problem hiding this comment.
Oh, so Legal API will set this before validating the schema?
There was a problem hiding this comment.
Does it have to be a declared property in this schema? I thought our schemas allowed additional properties without checks.
There was a problem hiding this comment.
As you can see from line no. 13 to 39 we have an "if -> then -> else", which is based on this field. Conditional Required based on isApproved value
There was a problem hiding this comment.
OK. Then this is fine by me.
Issue #: /bcgov/entity#23562
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-schemas license (Apache 2.0).