Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several bug fixes #124

Merged
merged 24 commits into from
Dec 13, 2023
Merged

Conversation

CeresBarros
Copy link
Member

@CeresBarros CeresBarros commented Dec 13, 2023

Along with fixing the function name issue noted in #118, there were several other issues causing the example used in downscale to fail (see comments in #118)

@CeresBarros CeresBarros added the bug Something isn't working label Dec 13, 2023
@codecov-commenter
Copy link

codecov-commenter commented Dec 13, 2023

Codecov Report

Attention: 20 lines in your changes are missing coverage. Please review.

Comparison is base (398631d) 5.43% compared to head (df58398) 5.48%.

❗ Current head df58398 differs from pull request most recent head c701cd6. Consider uploading reports for the commit c701cd6 to get more accurate results

Files Patch % Lines
R/dbGetRaster.R 0.00% 14 Missing ⚠️
R/downscale.R 0.00% 6 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            devl    #124      +/-   ##
========================================
+ Coverage   5.43%   5.48%   +0.04%     
========================================
  Files         21      21              
  Lines       1673    1660      -13     
========================================
  Hits          91      91              
+ Misses      1582    1569      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CeresBarros CeresBarros changed the title 118 normal_input is failing. Several bug fixes Dec 13, 2023
@CeresBarros CeresBarros marked this pull request as ready for review December 13, 2023 21:13
Copy link
Collaborator

@kdaust kdaust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@kdaust kdaust merged commit 32258e0 into bcgov:devl Dec 13, 2023
10 checks passed
@CeresBarros CeresBarros deleted the 118-normal_input-is-failing branch December 18, 2023 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants