Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

127 move all function definitions that are inside other functions to non-exported functions #128

Merged

Conversation

CeresBarros
Copy link
Member

@CeresBarros CeresBarros added the enhancement New feature or request label Dec 14, 2023
@codecov-commenter
Copy link

Codecov Report

Attention: 308 lines in your changes are missing coverage. Please review.

Comparison is base (32258e0) 5.48% compared to head (7b32e7d) 5.49%.

❗ Current head 7b32e7d differs from pull request most recent head 1fb1f86. Consider uploading reports for the commit 1fb1f86 to get more accurate results

Files Patch % Lines
R/gcm.R 0.00% 154 Missing ⚠️
R/downscale.R 0.00% 142 Missing ⚠️
R/lapserate.R 0.00% 12 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            devl    #128   +/-   ##
=====================================
  Coverage   5.48%   5.49%           
=====================================
  Files         21      21           
  Lines       1660    1657    -3     
=====================================
  Hits          91      91           
+ Misses      1569    1566    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CeresBarros CeresBarros merged commit bfd6d7d into bcgov:devl Dec 14, 2023
10 checks passed
@CeresBarros CeresBarros deleted the 127-move-all-function-definitions-that-a branch December 18, 2023 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants