Update Authentication approach and jsonwebtoken dependency #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jujaga
added
bug
|
Code Climate has analyzed commit 3042b73 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 80.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 60.8% (0.0% change). View more on Code Climate. |
Coverage Report
|
norrisng-bc
approved these changes
Jul 13, 2023
The jsonwebtoken library introduced a difficult to resolve fault with unit testing as of 9.0.0 where the decode function can no longer be spied or mocked. As the decode function is only really necessary if the publicKey is not specified, we instead reuse isValid's value when it is possible to do so instead. Signed-off-by: Jeremy Ho <jujaga@gmail.com>
jujaga
force-pushed
the
security/jwt-keycloak
branch
from
18c727b
to
3042b73
Compare
TimCsaky
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The jsonwebtoken library introduced a difficult to resolve fault with unit testing as of 9.0.0 where the decode function can no longer be spied or mocked. As the decode function is only really necessary if the publicKey is not specified, we instead reuse isValid's value when it is possible to do so instead.
SHOWCASE-3260
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist
Further comments