Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove no-db mode configuration #189

Merged
merged 1 commit into from
Jul 26, 2023
Merged

Remove no-db mode configuration #189

merged 1 commit into from
Jul 26, 2023

Conversation

TimCsaky
Copy link
Contributor

@TimCsaky TimCsaky commented Jul 24, 2023

Remove no-db mode

ticket: https://apps.nrs.gov.bc.ca/int/jira/browse/SHOWCASE-3241

removed no-db feature toggle
removed conditional logic
updated app.js startup checks
updated documentation
updated unit tests

Description

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@github-actions
Copy link

github-actions bot commented Jul 24, 2023

Coverage Report

Totals Coverage
Statements: 53.55% ( 1961 / 3662 )
Methods: 41.4% ( 219 / 529 )
Lines: 60.23% ( 1236 / 2052 )
Branches: 46.81% ( 506 / 1081 )

app/src/components/utils.js Show resolved Hide resolved
app/src/components/utils.js Show resolved Hide resolved
@codeclimate
Copy link

codeclimate bot commented Jul 24, 2023

Code Climate has analyzed commit d577dc2 and detected 8 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 8

The test coverage on the diff in this pull request is 29.8% (50% is the threshold).

This pull request will bring the total coverage in the repository to 60.2% (-0.3% change).

View more on Code Climate.

Copy link
Member

@jujaga jujaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I could tell things seem to be working across most endpoints. We'll want to simply and remove unneeded IIFEs as well as consider putting more enforcement logic for when db.* isn't defined or partially missing.

app/app.js Show resolved Hide resolved
app/src/validators/object.js Outdated Show resolved Hide resolved
app/src/validators/object.js Outdated Show resolved Hide resolved
app/src/validators/object.js Outdated Show resolved Hide resolved
app/src/validators/object.js Show resolved Hide resolved
app/src/validators/version.js Outdated Show resolved Hide resolved
app/src/validators/version.js Outdated Show resolved Hide resolved
@TimCsaky TimCsaky force-pushed the nodb branch 3 times, most recently from 08e45a0 to 2166cc4 Compare July 25, 2023 23:59
removed no-db feature toggle
removed conditional logic
updated app.js startup checks
updated documentation
updated unit tests
@jujaga jujaga merged commit 3b8e931 into master Jul 26, 2023
12 checks passed
@jujaga jujaga deleted the nodb branch July 26, 2023 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants