Implement synchronization endpoints #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Release 1b43b01 deployed at https://coms-dev-pr-190.apps.silver.devops.gov.bc.ca |
TimCsaky
approved these changes
Jul 25, 2023
norrisng-bc
reviewed
Jul 25, 2023
norrisng-bc
approved these changes
Jul 26, 2023
jujaga
force-pushed
the
release/sync
branch
2 times, most recently
from
751bee7
to
77a20cf
Compare
Signed-off-by: Jeremy Ho <jujaga@gmail.com>
Also fix some minor unit test issues Signed-off-by: Jeremy Ho <jujaga@gmail.com>
Modify listAllObjects to default to empty string when path is only the delimiter. This is needed as pattern matching does not handle the root '/' context well. Signed-off-by: Jeremy Ho <jujaga@gmail.com>
jujaga
force-pushed
the
feature/apisync
branch
2 times, most recently
from
00859ad
to
8e57650
Compare
jujaga
force-pushed
the
feature/apisync
branch
2 times, most recently
from
3b11cc5
to
6418f20
Compare
In order to reduce code duplication, we reuse the syncBucket controller with a few value tweaks so that it can handle both endpoint types. We also move the sync* controller functions to the sync controller in order to reduce controller pollution of the large object and bucket controllers, and invoke these functions directly through the router instead. Lastly, some database layer modifications are done in order to allow bucketId to accept null fields. Signed-off-by: Jeremy Ho <jujaga@gmail.com>
TimCsaky
approved these changes
Jul 27, 2023
TimCsaky
approved these changes
Jul 28, 2023
jujaga
pushed a commit
that referenced
this pull request
Aug 14, 2023
Implement synchronization endpoints
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces and exposes the synchronization logic to the COMS API. We also implement a listAllObjectVersions storageService call in order to allow a more robust way of detecting, paginating and enumerating soft-deleted files.
SHOWCASE-3257
Types of changes
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Checklist
Further comments