Skip to content

Commit

Permalink
Feature/descw 2516 dependency maintenance (#51)
Browse files Browse the repository at this point in the history
* Updated package.json scripts and workflows to use npm ci
* Locked client/ vuetify dependency to minor version as later version fail during built
* Upgraded bootstrap to v5
  • Loading branch information
mhaswell-bcgov authored Aug 15, 2024
1 parent 1417809 commit 9f864d9
Show file tree
Hide file tree
Showing 8 changed files with 2,635 additions and 3,882 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/buildTestPublishContainerDeploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
node-version: ${{ vars.NODE_VERSION }}
- name: Install, build, lint and test:e2e 🔧
run: |
npm install
npm ci
npm run build
npm run lint
npm run test:e2e
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ghPages.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ jobs:
- name: Install and Build 🔧 # This example project is built using npm and outputs the result to the 'build' folder. Replace with the commands required to build your project, or remove this step entirely if your site is pre-built.
run: |
cd docs
npm install
npm ci
npm run build
- name: Deploy 🚀
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ RUN mkdir /home/node/app/logs/ && touch /home/node/app/logs/access.log
# Bundle app source code
COPY --chown=node . .

RUN npm i --omit=optional && npm run build && npm i --omit=dev --omit=optional
RUN npm ci --omit=optional && npm run build && npm ci --omit=dev --omit=optional

ENV HOST=0.0.0.0 PORT=3000 SMTP_PORT=2525 NODE_ENV=production NOTIFYBC_WORKER_PROCESS_COUNT=1

Expand Down
51 changes: 21 additions & 30 deletions client/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions client/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"devDependencies": {
"@json-editor/json-editor": "^2.10.1",
"@vitejs/plugin-vue": "^4.6.2",
"bootstrap": "^4.6.0",
"bootstrap": "~5.0.0",
"ejs": "^3.1.9",
"eslint": "^8.37.0",
"eslint-plugin-vue": "^9.3.0",
Expand All @@ -34,7 +34,7 @@
"vite-plugin-vuetify": "^1.0.0",
"vue": "^3.2.0",
"vue-router": "^4.0.0",
"vuetify": "^3.0.0"
"vuetify": "~3.3.0"
},
"eslintConfig": {
"root": true,
Expand Down
Loading

0 comments on commit 9f864d9

Please sign in to comment.