Added support for PRs in chartReleaser workflow #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhaswell-bcgov
commented
Jul 15, 2024
•
mhaswell-bcgov
commented
- PRs automatically trigger temporary charts to be released using the current Chart.yaml version (eg. this PR automatically released a 5.1.2-pr42 chart). The workflow only runs automatically if files inside helm/ are changed
- The manual workflow run input no longer requires the user to input the entire chart version. It automatically takes the version from the Chart.yaml and appends the user input to it to create the tag. Because of this, we can no longer overwrite a release chart (eg. 5.1.2 with no hyphen) as the input won't allow it.
- It's still possible to overwrite a release chart by creating a GH Release and not updating the version in Chart.yaml to match the release tag.
Testing chartReleaser getting the current chart.yaml version
mhaswell-bcgov
requested review from
ShawnTurple,
ASpiteri-BCGov,
kshapka-bcgov and
robrien-bcgov
.github/workflows/chartReleaser.yml
Outdated
| workflow_dispatch: | ||
| inputs: | ||
| chart_version: | ||
| description: 'The chart version to create. Must be a valid semver string and should indicate that it is not a release chart version (eg. 5.1.2-pr36).' | ||
| description: 'The chart version to create. Will be appended to the current version from helm/Chart.yaml (eg. "pr36" on Chart.yaml version: 5.1.2 produces "5.1.2-pr36").' |
There was a problem hiding this comment.
This isn't the most clearly worded (although the example is very useful). This is a sub-version or suffix essentially, right?
There was a problem hiding this comment.
Yeah reading it back it wasn't very clear. How does this one read?
kshapka-bcgov
approved these changes
Jul 16, 2024
mhaswell-bcgov
added a commit
that referenced
this pull request
Jul 26, 2024
* Added support for PRs in chartReleaser workflow * Added path to image build to avoid rebuilding image when src hasn't changed * Improved wording of workflow input description
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.