Feature/notify 12 log dating #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhaswell-bcgov
requested review from
ShawnTurple,
kshapka-bcgov,
ASpiteri-BCGov and
robrien-bcgov
robrien-bcgov
approved these changes
Aug 27, 2024
| - To add any other custom values (to change the image version, for example), add another `-f` flag pointing to your values yaml file. | ||
| 4. To undo a deployment, run the command `helm delete local`. | ||
| - If you used a different release name in the previous step, replace `local` with that release name. | ||
|
|
There was a problem hiding this comment.
this seems easy to follow. I like numbered lists with actual commands in them
| Tag app.access.log | ||
| Mem_Buf_Limit 5MB | ||
| Name tail | ||
| Path /tmp/logs/*.log |
There was a problem hiding this comment.
I thought it would be easier to read if the values were aligned with each other.
| Name Lua | ||
| Match * | ||
| call append_tag | ||
| code function append_tag(tag, timestamp, record) new_record = record new_record["datestamp"] = os.date("%Y%m%d", timestamp) return 1, timestamp, new_record end |
There was a problem hiding this comment.
cool - Lua code!
seems to be appending a tag to each record containing a datestamp.
There was a problem hiding this comment.
That's right. It's pretty hacky but I'm just wanting to finish this thing up even if it isn't done in the best way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.