Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retiring Platform Services team content from DevHub #1771

Merged
merged 8 commits into from
Sep 15, 2022

Conversation

ty2k
Copy link
Contributor

@ty2k ty2k commented Sep 7, 2022

This pull request relates to the issue #2757 Remove PS Team's migrated content from DevHub, following up on the changes made in #1766, which added placeholder content for pages that are being retired from DevHub.

The changes in this PR remove references to Platform Services team documents in DevHub, replacing them with the new placeholder content pages from #1766. This is done in a way that preserves the use of each page's current URL, so that URLs indexed by search engines or bookmarked by users will still work, but will point to boilerplate text telling them to look in the Private Cloud site or the Private Cloud Technical Documentation site.

Example: Current production page for "Agile Delivery Process"
Agile Delivery Process page in production

Updated "Agile Delivery Process" page
Agile Delivery Process page in local development

@ty2k ty2k self-assigned this Sep 7, 2022
@ty2k ty2k requested a review from w8896699 as a code owner September 7, 2022 22:56
@repo-mountie
Copy link
Contributor

repo-mountie bot commented Sep 7, 2022

@ty2k When a pull request (PR) is over the 200-400 line range (of change) the ability of the reviewer to effectively detect issues quickly diminishes. Your PR is over the preferred length of 300 lines set for this repo. While this cannot always be avoided, please be mindful of the reviewer's time by organizing your work into smaller, more manageable PRs.

Here are a few thoughtful articles on what a good PR should look like:

The Anatomy of a Perfect Pull Request

Optimal Pull Request Size

Best Practices for Code Review

Pro Tip

  • Add the command /bot-ignore-length in the body (preferably as the last line) of a PR if you have a legitimate reason for lengthy PR.

@devhub-cicd
Copy link
Contributor

devhub-cicd bot commented Sep 7, 2022

Fancy seeing you here partner 🤠
I'm @deploy-tron. First time seeing me? Run @deploy-tron help to get started.

Keep in mind only authorized users will be able to trigger commands :)

@ty2k
Copy link
Contributor Author

ty2k commented Sep 9, 2022

@deploy-tron deploy web to dev

@devhub-cicd
Copy link
Contributor

devhub-cicd bot commented Sep 9, 2022

Deployment Created

Deployment 647411689 to development created :)

The deployment has the following payload which you can integrate with your ci/cd service.

{"microservice":"web","pr":1771,"user":"ty2k"}

@ty2k
Copy link
Contributor Author

ty2k commented Sep 15, 2022

@deploy-tron deploy web to test

@devhub-cicd
Copy link
Contributor

devhub-cicd bot commented Sep 15, 2022

Deployment Created

Deployment 651929532 to staging created :)

The deployment has the following payload which you can integrate with your ci/cd service.

{"microservice":"web","pr":1771,"user":"ty2k"}

@github-actions
Copy link

Deployment to staging succeeded!

@ty2k
Copy link
Contributor Author

ty2k commented Sep 15, 2022

@deploy-tron deploy web to prod

@devhub-cicd devhub-cicd bot temporarily deployed to production September 15, 2022 16:11 Inactive
@devhub-cicd
Copy link
Contributor

devhub-cicd bot commented Sep 15, 2022

Deployment Created

Deployment 651934737 to production created :)

The deployment has the following payload which you can integrate with your ci/cd service.

{"microservice":"web","pr":1771,"user":"ty2k"}

@github-actions
Copy link

Deployment to production succeeded!

@github-actions
Copy link

Cleaning up dev artifacts and build artifacts

@ty2k
Copy link
Contributor Author

ty2k commented Sep 15, 2022

I'm going to try merging this without review as I need the "If you can't find..." text from fb4f663 in the master branch to be able to deploy that (in a new PR). Any changes, I will fix going forward.

@ty2k ty2k merged commit 9af2615 into master Sep 15, 2022
@ty2k ty2k deleted the migrated-topics-ref-change branch September 15, 2022 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants