Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RESET - name_state.state_comment is being saved as '' instead of NULL #111

Closed
JohnamLane opened this issue Jan 21, 2019 · 0 comments
Closed
Assignees
Labels
bug Something isn't working NameX NameX and related services proxied via namex

Comments

@JohnamLane
Copy link
Collaborator

Symptom:
When an NR is reset and then approved in NameX, the 'Reason' label shows in the NRO Transaction History screen under the approved name.

Desired outcome:
The reason label is used for rejections, so it should not show for approvals. The reset feature currently saves an empty string back to the name_state.state_comment field in NAMESP. This is not a NULL value, so the NRO app thinks there is a value there. To correct, save NULL instead of ''.

Steps to reproduce:

  1. Find rejected name in NameX that has a conflict
  2. Reset the name then approve it
  3. The reason label will be present.

image.png

@JohnamLane JohnamLane added the bug Something isn't working label Jan 21, 2019
@pwei1018 pwei1018 self-assigned this Jan 24, 2019
@LJTrent LJTrent added the NameX NameX and related services proxied via namex label Feb 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working NameX NameX and related services proxied via namex
Projects
None yet
Development

No branches or pull requests

5 participants