Save the state_comment value to NULL when it is a empty string #519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e_examination function Signed-off-by: PWEI <patrick.wei@gov.bc.ca>
Signed-off-by: PWEI <patrick.wei@gov.bc.ca>
katiemcgoff
approved these changes
Feb 7, 2019
There was a problem hiding this comment.
Looks good to me. @thorwolpert please also review in terms of the SQL release plan, just to make sure it complies with our standard. I believe it does but I'm not 100% confident that I'd catch an issue in this case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bcgov/entity#111
Description of changes:
Update oracle package NRO_DATAPUMP_PKG.name_examination function and set state_comment to NULL if it is a empty string.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namex license (Apache 2.0).