Save the state_comment value to NULL when it is a empty string (#519)

* Save the state_comment value to NULL when it is a empty string in name_examination function

Signed-off-by: PWEI <patrick.wei@gov.bc.ca>

* Move the package file to object folder and create release file

Signed-off-by: PWEI <patrick.wei@gov.bc.ca>

docs/legacy/nro_datapump_pkg_body.sql

@@ -1370,7 +1370,7 @@ END;
  AND ns.end_event_id IS NULL;
 
  INSERT INTO name_state(name_state_id, name_id,start_event_id,end_event_id,name_state_type_cd,state_comment)
- VALUES(name_state_seq.nextval, ni_rec.name_id, l_event_id, NULL, l_state_code, l_state_comment);
+ VALUES(name_state_seq.nextval, ni_rec.name_id, l_event_id, NULL, l_state_code, TRIM(l_state_comment));
 
  -- now insert conflicting names:
  IF (ni_rec.choice_number = 1) THEN

nro-legacy/sql/object/names/namesdb/package/nro_data_pump_pkg.sql

@@ -0,0 +1,59 @@
+CREATE OR PACKAGE nro_datapump_pkg AS
+
+
+ --
+ --
+ PROCEDURE update_request_state(nr_number IN VARCHAR2,
+ status IN VARCHAR2,
+ expiry_date IN VARCHAR2,
+ consent_flag IN VARCHAR2,
+ examiner_id IN VARCHAR2,
+ exam_comment IN VARCHAR2 DEFAULT NULL,
+ add_info IN VARCHAR2 DEFAULT NULL,
+ p_corp_num IN VARCHAR2 DEFAULT NULL);
+
+ --
+ --
+ PROCEDURE update_name_state(nr_number IN VARCHAR2,
+ name_choice IN VARCHAR2,
+ accept_reject_flag IN VARCHAR2,
+ reject_condition IN VARCHAR2 DEFAULT NULL);
+
+
+ PROCEDURE update_name_rule(nr_number IN VARCHAR2,
+ name_choice IN VARCHAR2,
+ conflicting_number IN VARCHAR2,
+ conflicting_name IN VARCHAR2 DEFAULT NULL);
+
+ PROCEDURE make_historical(p_corp_num IN VARCHAR2,
+ p_corp_type IN VARCHAR2,
+ p_corp_name IN VARCHAR2 DEFAULT NULL);
+
+ PROCEDURE consume_request(p_nr_num IN VARCHAR2,
+ p_corp_num IN VARCHAR2);
+
+ PROCEDURE name_examination(p_nr_number IN VARCHAR2,
+ p_status IN VARCHAR2,
+ p_expiry_date IN VARCHAR2,
+ p_consent_flag IN VARCHAR2,
+ p_examiner_id IN VARCHAR2,
+ p_choice1 IN VARCHAR2 DEFAULT 'NE',
+ p_choice2 IN VARCHAR2 DEFAULT 'NA',
+ p_choice3 IN VARCHAR2 DEFAULT 'NA',
+ p_exam_comment IN VARCHAR2 DEFAULT NULL,
+ p_add_info IN VARCHAR2 DEFAULT NULL,
+ p_confname1A IN VARCHAR2 DEFAULT 'NA',
+ p_confname1B IN VARCHAR2 DEFAULT 'NA',
+ p_confname1C IN VARCHAR2 DEFAULT 'NA',
+ p_confname2A IN VARCHAR2 DEFAULT 'NA',
+ p_confname2B IN VARCHAR2 DEFAULT 'NA',
+ p_confname2C IN VARCHAR2 DEFAULT 'NA',
+ p_confname3A IN VARCHAR2 DEFAULT 'NA',
+ p_confname3B IN VARCHAR2 DEFAULT 'NA',
+ p_confname3C IN VARCHAR2 DEFAULT 'NA');
+
+ FUNCTION format_corp_num(p_corp_num IN VARCHAR2) RETURN name_instance.corp_num%TYPE;
+
+ FUNCTION Dummy RETURN VARCHAR2;
+
+END nro_datapump_pkg;