Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EDIT: Should not be able to save name choice 3 when name choice 2 is blank #126

Closed
perkinss opened this issue Jan 31, 2019 · 4 comments
Closed
Assignees
Labels
NameX NameX and related services proxied via namex Priority1

Comments

@perkinss
Copy link

perkinss commented Jan 31, 2019

Currently when you edit name choices on a request that has only one name, you can enter a value in the 3rd field and leave the second field blank. This makes no sense.

I cannot imagine a valid case where my first choice would be "Acme", I have no second choice, but just in case my second choice is also unacceptable, please consider my third choice, "Roadrunner"

@perkinss perkinss self-assigned this Jan 31, 2019
@perkinss
Copy link
Author

Could:

  1. Post an error similar to when the first field is blank, which also disables the saving action (although, curiously, not the save button itself)
  2. Disable the 3rd field until the 2nd field is filled, and the 2nd until the 1st is filled.
  3. When the NR is saved, move the 3rd choice to the 2nd if the 2nd name choice was empty on save

@perkinss
Copy link
Author

Going with 2 unless someone says otherwise

@perkinss
Copy link
Author

perkinss commented Feb 4, 2019

In the API we're also not handing it, so there's a new ticket, #136

@perkinss
Copy link
Author

perkinss commented Feb 4, 2019

After further discussion with @forgeuxGH5 on @katiemcgoff's feedback, we'll take the error message approach. So:
If field 3 is full and the user clears field 2, they should see an error message similar to the one under field 1 when it gets cleared. And save should likewise be disabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NameX NameX and related services proxied via namex Priority1
Projects
None yet
Development

No branches or pull requests

4 participants