126 edit validation fixes #1238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kial Jinnah <kialj876@gmail.com>
Signed-off-by: Kial Jinnah <kialj876@gmail.com>
katiemcgoff
suggested changes
Mar 1, 2019
There was a problem hiding this comment.
If you have time:
looks like this validation (and the existing validation on name 1) doesn't handle spaces properly, ie: if you just enter a single space, it thinks that name 1 or name 2 is filled in. This is a downfall of the vuelidate "required" checker and could be handled by adding a custom "not blank" checker as well. See the custom validation on nwpta dates for example.
If you don't get to this before you want to deploy that's fine, it can be logged as a separate task since it's half pre-existing (name 1) and half new (name 2).
Signed-off-by: Kial Jinnah <kialj876@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #:bcgov/entity#126
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namex license (Apache 2.0).