UI: Conversion of HomeOwners table to Simple Table

[cameron-eyds]

The scope of this ticket is to downgrade our v-data-tables into v-simple-tables in order to facilitate an easier transition to Vuetify 3.

This is part two of the data table conversions, to handle the more complex tables remaining.
Tables:

• HomeOwnersTable

[dimak1]

Hi @chdivyareddy, as part of the table conversion, we need to do regression testing (including UI) for the following:

• Home Owners Table (Mhr Reg & Transfers) Eg: Sole Owners, Joint Tenants, Groups, Show/Hide Deleted Owners
• Adding multiple Executors, Admin, etc. (including Suffix) in Transfers
• Home Owners Review & Confirm page (Mhr Reg & Transfers)
• Validations (Errors for no owners, no groups, mixed owners, etc.)
• Submission

Thank you!

[saragunnarsson]

@dimak1 UXA is still in progress, I'll msg you when it's done.

Transfer due to sale or gift

• I edited an added owner, I selected group 2 in the dropdown, but once selected the value didn’t show up. I clicked the dropdown again and group 2 was not there anymore, I could only select group 1
  

• Even though the value wasn't showing up I could click done and the owner got added to group 2. However the interest allocation that was previously there, disappeared.

• The group headers are too close to the left edge. “Group 1” and “added” badge should line up with the owner icon and “name” (see dotted line). I only see this happening for Transfer due to sale or gift and registration.
  

• When i click edit on the first owner listed in a group, the edit for the first owner listed in every group opens. When i click done in one of the forms, all forms closed.

Similarly, if I click edit on the second owner in a group, then the forms for all owners listed as number 2 in all groups opens.

• Deleted all groups and got this duplicated message in each owner row, should only be at the top of the table
  

[dimak1]

@saragunnarsson thanks for the feedback (so far). I will address these after I'm done with a ticket Im currently working on.

[saragunnarsson]

Registration

I added sally as a sole owner and then added Helen so they became joint tenants.
I then edited sally and added her to group 1
Both owners became part of group 1 so I edited Helen and added her to group 2.

Problems:

• The group interest allocation went away. (Dima: Same behaviour prior to table conversion)
• The group headings are too close to the left edge (same as noted above in transfer due to sale or gift)
• The edit person form opens for multiple owners at the same time (Same as noted above for transfer due to sale or gift)
  

[saragunnarsson]

@dimak1 Ok I'm done :) Most issues seems to be in sale or gift transfer + registration. One more issue found below..

Review and confirm screen (all transfers)

• These borders should go to the end (line up with the rest)
  

[dimak1]

Thanks for the feedback @saragunnarsson. I started to work on these items.

[chdivyareddy]

Hey @dimak1 , while you are working on this ticket, just wanted to add a scenario from Transfers, please take a look, thanks!

• In the transfer flow, the mailing address, phone number and 'Delete' buttons are moved little off to the left in the home owners table:
  

[dimak1]

Hi @chdivyareddy yes, I'm still working on it. Will take a look, thank you!

[dimak1]

Opened a PR to address the issues above, however, I couldn't reproduce the following (as noted above):

• Review Page: Borders should go to the end (line up with the rest)
• Transfer due to sale or gift: I edited an added owner, I selected group 2 in the dropdown, but once selected the value didn’t show up. I clicked the dropdown again and group 2 was not there anymore, I could only select group 1. Even though the value wasn't showing up I could click done and the owner got added to group 2. However the interest allocation that was previously there, disappeared.
• In the transfer flow, the mailing address, phone number and 'Delete' buttons are moved little off to the left in the home owners table.

The following is not an issue (for this ticket) as it existed prior to the conversion.

• The group interest allocation went away.

cc: @chdivyareddy @tlebedovich

[chdivyareddy]

Hey @dimak1 , just to confirm on the home owners table for the registration and transfers, mailing address, phone number and Delete/Edit buttons are moved little off to the left. I still see this issue in DEV. Can you please take a look.

[dimak1]

@chdivyareddy I couldn't reproduce it. Let me take a look again.

[dimak1]

@chdivyareddy I wasn't able to reproduce. But then I tried Safari and saw the issue. So it is browser-specific, working on the fix now.

[dimak1]

@chdivyareddy this has been fixed and promoted to DEV.

[chdivyareddy]

Hey @dimak1 , Please look at the following scenarios..(Will add here If I find any), thanks!!

• For the MHR 107750 in DEV, when I selected an executor to edit the details in the Group1, then the Additional Name Information section is auto cleared and when trying to click on the Done button, then the validation for the Additional name information section "This field is required" is not displayed in red error message and cannot add the details into it (uneditable or read only section)
  

• When I tried to submit a transfer (MHR 107750 in DEV) which contains executor in one group and administrator in other group (no mix of owners), then the submission fails with the following error:

{
    "errorMessage": "API backend third party service error.",
    "rootCause": "detail:[Additional validation: Owner party type of administrator, executor, trustee not allowed for this registration. Owner party type of administrator, executor, trustee not allowed for this registration. Owner party type of administrator, executor, trustee not allowed for this registration. Owner description is required for the owner party type. Owner party type of administrator, executor, trustee not allowed for this registration. ],message:003: Registration request data validation errors. "
}

[dimak1]

Thanks @chdivyareddy, will take a look.

[dimak1]

@chdivyareddy quick update, I found the problem with issue 1 (Additional Name) and working on fixing it. Basically it's the suffix and description that correspond to the same Additional Name field. For the second issue, it might be related to the first one, we also need to wait to merge Mixed Owners validation, because UI is not stopping you from having different owners, so the API fails. Those Owners in the table could have different roles, other than what Additional Name is showing.

[dimak1]

Opened PR with fixes. Will check preview url before moving the ticket forward.

[dimak1]

@chdivyareddy Issue #1 is fixed and ready to be merged to Dev.

Issue #2 is not an issue as per API, we cannot have Admins, Exec, and Trustees in the table when doing Sale/Gift Transfers. Maybe there should be something in UI to show that. cc: @tlebedovich

[tlebedovich]

@dimak1 @chdivyareddy @doug-lovett - There can be previously existing Admins OR Execs OR Trustees (can't have a mix of these in a single group) in an ownership/group when you are doing a sale/gift transfer, you just can't add NEW owner that have these roles as New owners in Sale/Gift can only be added as "regular Owners". And if you have a previously existing group of owners that has admins OR execs OR trustees (can't have a mix of these in a single group) and then add a NEW "regular Owner" to that same group, then the user should see the mismatch owner role error message appear for that ownership group. -------- If you have a Tenants in Common and Group 1 has admin(s) and Group 2 has "regular Owners", then you are allowed to add a new "regular Owner" to Group 2. ------ Another example scenario: You can have a previously existing Exec in a group for sale/gift, delete them and then add a new "regular Owner" to that group. If you undelete the Exec, you now have mismatched roles and will again see the mismatched roles error message. Let me know if you need a call to clarify.

[chdivyareddy]

@tlebedovich thanks for clarifying!

[dimak1]

@chdivyareddy ready for verification (minus issue 2).

[chdivyareddy]

Verified in DEV, transfer flow with groups will be verified in 17002.