Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Home Owners conversion UXA feedback #1408

Merged
merged 2 commits into from
Jun 30, 2023

Conversation

dimak1
Copy link
Collaborator

@dimak1 dimak1 commented Jun 30, 2023

Issue #:

Description of changes:

  • Updates to address the UXA feedback

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the PPR license (Apache 2.0).

@dimak1 dimak1 added the UXA Updates for UXA feedback label Jun 30, 2023
@dimak1 dimak1 self-assigned this Jun 30, 2023
@dimak1
Copy link
Collaborator Author

dimak1 commented Jun 30, 2023

/gcbrun

@codecov
Copy link

codecov bot commented Jun 30, 2023

Codecov Report

Merging #1408 (2a01bd7) into main (9255e77) will increase coverage by 4.81%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1408      +/-   ##
==========================================
+ Coverage   72.35%   77.16%   +4.81%     
==========================================
  Files         307      330      +23     
  Lines       12767     6101    -6666     
  Branches     2630      962    -1668     
==========================================
- Hits         9237     4708    -4529     
+ Misses       3518     1360    -2158     
- Partials       12       33      +21     
Flag Coverage Δ
pprui 77.16% <100.00%> (+4.81%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
ppr-ui/src/components/common/BaseSnackbar.vue 100.00% <ø> (ø)
ppr-ui/src/components/common/ButtonsStacked.vue 100.00% <ø> (+12.50%) ⬆️
...pr-ui/src/components/common/CertifyInformation.vue 100.00% <ø> (+20.54%) ⬆️
...pr-ui/src/components/common/ContactInformation.vue 100.00% <ø> (ø)
ppr-ui/src/components/common/ContactUsToggle.vue 100.00% <ø> (ø)
ppr-ui/src/components/common/CourtOrder.vue 100.00% <ø> (+10.47%) ⬆️
ppr-ui/src/components/common/DatePicker.vue 100.00% <ø> (+15.38%) ⬆️
.../src/components/common/DischargeConfirmSummary.vue 100.00% <ø> (ø)
ppr-ui/src/components/common/DocumentId.vue 100.00% <ø> (ø)
ppr-ui/src/components/common/ErrorContact.vue 100.00% <ø> (ø)
... and 142 more

... and 99 files with indirect coverage changes

@pwei1018
Copy link
Collaborator

Temporary Url for review: https://bcregistry-assets-dev--pr-1408-xfwox6tw.web.app

Copy link
Collaborator

@cameron-eyds cameron-eyds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@dimak1 dimak1 merged commit 7e2db1f into bcgov:main Jun 30, 2023
7 checks passed
@dimak1 dimak1 deleted the uxa/home-owners-conversion branch November 20, 2023 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UXA Updates for UXA feedback
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants