Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start a new BC company should not have Xpro options in Jurisdiction. #17152

Closed
riyazuddinsyed opened this issue Jul 20, 2023 · 7 comments
Closed
Assignees
Labels
bug Something isn't working ENTITY Business Team Priority2 SRE SRE team task UX Assurance

Comments

@riyazuddinsyed
Copy link
Collaborator

riyazuddinsyed commented Jul 20, 2023

Describe the bug in the current situation
When the user tries to start a new BC-based company then the Select Jurisdiction shows the Extraprovinsial option which isn't valid in this case.

Steps to reproduce the behavior:

  1. Go to 'https://namerequest-dev--pr-628-mefl84wf.web.app/'
  2. Click on 'Start a new BC Based company'
  3. Go to Select Jurisdiction
  4. Notice the Extraprovinsional options.
  5. The wire frame doesn't show the option to select Extraprovinsional Jurisdiction

Link to uxpin with various scenarios:
https://preview.uxpin.com/a86dccdd20ac62828f965c5eea10f81b828a9853#/pages/163136223/simulate/sitemap

@severinbeauvais
Copy link
Collaborator

Test Notes

Here is the temporary URL (as this is still on the feature branch):
https://namerequest-dev--pr-633-vjah8ctg.web.app/

@severinbeauvais
Copy link
Collaborator

@yuisotozaki @janisrogers Could you have a look at the changes I made, please?

@yuisotozaki
Copy link

yuisotozaki commented Jul 28, 2023

The main objective seems good - I don't see the Jurisdiction field any more for new regi/inc.
Observations:

  1. The only thing is when I select the new regi/inc option, then I re-click the field and select a major category like "For businesses that do not exist yet:", the Select an Action field clears but the Select type of business B.C. field doesn't reset to empty.
  2. The emptiness of the second field at initial state looks odd - maybe Ethan's design will take care of a placeholder field or something later on. Confirmed coverage in Ethan's visual design. We can handle this later.

@severinbeauvais
Copy link
Collaborator

  1. The only thing is when I select the new regi/inc option, then I re-click the field and select a major category like "For businesses that do not exist yet:", the Select an Action field clears but the Select type of business B.C. field doesn't reset to empty.

This is a side-effect of the action field being cleared (incorrectly, per 17044) but the memory variables are still set. I am trying to solve both issues at once.

@severinbeauvais
Copy link
Collaborator

@severinbeauvais
Copy link
Collaborator

Or @ethantspitt ^^

@yuisotozaki
Copy link

The master-dependent fields behave as expected. Ready for QA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ENTITY Business Team Priority2 SRE SRE team task UX Assurance
Projects
None yet
Development

No branches or pull requests

4 participants