17152 Menu UI improvements #635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- now return item object so we don't have to find it - added class to disabled items - now include but disable items not in active group - hide disabled list items via CSS
severinbeauvais
requested review from
eve-git,
ketaki-deodhar,
JazzarKarim and
leodube-aot
severinbeauvais
commented
Aug 2, 2023
| @@ -17,8 +17,15 @@ | |||
| item-value="[group,value]" | |||
| :menu-props="{ bottom: true, offsetY: true, maxHeight: 423 }" | |||
| @change="setClearErrors(null); onRequestActionChange($event)" | |||
| return-object | |||
There was a problem hiding this comment.
This returns the entire item object (in $event) instead of just its value.
severinbeauvais
commented
Aug 2, 2023
| <!-- <template #selection="{ item }"> | ||
| <div class="font-weight-bold text-truncate">{{ item.text }}</div> | ||
| <div class="text-subtitle-1">{{ item.subtext }}</div> | ||
| </template> --> |
There was a problem hiding this comment.
I played with this a little on Janis' and Ethan's request, and we decided to not pursue this yet, but I left the code here for the next dev.
Sample:
^^ plus some CSS to tighten up line heights/margins
|
/gcbrun |
severinbeauvais
commented
Aug 2, 2023
| @@ -32,9 +39,12 @@ | |||
| </div> | |||
| </v-list-item-content> | |||
|
|
|||
| <!-- render but conditionally hide disabled list items, so that the v-select | |||
| continues to display the current selection even when a different group is active --> | |||
There was a problem hiding this comment.
If the item is not in the list then the v-select sometimes shows a blank selection (ticket 17044).
severinbeauvais
commented
Aug 2, 2023
| <v-list-item-content | ||
| v-else | ||
| class="group-item pl-8 pr-4 py-4" | ||
| :class="{ 'hide-me': item.disabled }" |
There was a problem hiding this comment.
Can't just use d-none because it's actually the parent element I need to hide.
JazzarKarim
reviewed
Aug 2, 2023
|
Temporary Url for review: https://namerequest-dev--pr-635-hnknd6zs.web.app |
severinbeauvais
merged commit ef3d33c
into
bcgov:feature-way-of-navigating
5 checks passed
JazzarKarim
pushed a commit
to JazzarKarim/namerequest
that referenced
this pull request
Aug 24, 2023
- now return item object so we don't have to find it - added class to disabled items - now include but disable items not in active group - hide disabled list items via CSS
JazzarKarim
pushed a commit
to JazzarKarim/namerequest
that referenced
this pull request
Aug 24, 2023
- now return item object so we don't have to find it - added class to disabled items - now include but disable items not in active group - hide disabled list items via CSS
JazzarKarim
pushed a commit
to JazzarKarim/namerequest
that referenced
this pull request
Sep 8, 2023
- now return item object so we don't have to find it - added class to disabled items - now include but disable items not in active group - hide disabled list items via CSS
JazzarKarim
pushed a commit
that referenced
this pull request
Sep 11, 2023
- now return item object so we don't have to find it - added class to disabled items - now include but disable items not in active group - hide disabled list items via CSS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: /bcgov/entity#17152
Description of changes:
- app version = 5.0.12
- now return item object so we don't have to find it
- added class to disabled items
- now include but disable items not in active group
- hide disabled list items via CSS
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namerequest license (Apache 2.0).