Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Namex: cannot handle multiple REAPPLY payments of a NR #17411

Closed
eve-git opened this issue Aug 15, 2023 · 5 comments
Closed

Namex: cannot handle multiple REAPPLY payments of a NR #17411

eve-git opened this issue Aug 15, 2023 · 5 comments
Assignees
Labels
bug Something isn't working SRE SRE team task

Comments

@eve-git
Copy link
Collaborator

eve-git commented Aug 15, 2023

A NR can be 'REAPPLY' for multiple times. Except the first payment for reappply, other payments are just logged but no corresponding payment record created.

The following post method seems can only handle payment of an unique action of a NR:
https://github.com/bcgov/namex/blob/7499db7f284e1bf888ee71e57596e7743b636fb0/api/namex/resources/payment/payment.py#L358C13-L358C14

payment action is one of [CREATE, UPGRADE, REAPPLY, RESUBMIT]. 'CREATE' and 'UPGRADE' can be applied for once per NR. A new NR is created when resubmit. So, only 'REAPPLY' has the problem.

See more details @ https://github.com/bcgov-registries/ops-support/issues/2968

@eve-git eve-git added bug Something isn't working SRE SRE team task labels Aug 15, 2023
@bolyachevets bolyachevets self-assigned this Aug 24, 2023
@PCC199 PCC199 closed this as completed Sep 19, 2023
@severinbeauvais
Copy link
Collaborator

Has this been tested (QAed) and can be deployed to Test and Prod?

@bolyachevets
Copy link
Collaborator

Has this been tested (QAed) and can be deployed to Test and Prod?

it is in prod as of this week: https://app.zenhub.com/workspaces/sre-team-space-61685e965bfb35001dac5771/reports/release?release=Z2lkOi8vcmFwdG9yL1JlbGVhc2UvOTUyODc

@severinbeauvais
Copy link
Collaborator

severinbeauvais commented Sep 21, 2023

I know it's tagged to the above release, but I think the commit came AFTER the code was last pushed to Test. So I think it's not yet in Test or Prod.

(The above release deployed Test -> Prod on Sept 19.)

@bolyachevets
Copy link
Collaborator

I know it's tagged to the above release, but I think the commit came AFTER the code was last pushed to Test. So I think it's not yet in Test or Prod.

(The above release deployed Test -> Prod on Sept 19.)

you are right, it looks the build in prod is from August 15th's commit. @ozamani9

@severinbeauvais
Copy link
Collaborator

severinbeauvais commented Sep 21, 2023

Well, you're in the Way of Navigating release that Entity Team has been working on, will deploy to Test ASAP, and plans to deploy to Prod on Oct 17.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working SRE SRE team task
Projects
None yet
Development

No branches or pull requests

4 participants