17411 - don't skip valid cases of reapply payments #1412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bolyachevets
requested review from
pwei1018,
eve-git,
thorwolpert,
stevenc987,
mengdong19,
ozamani9gh and
rarmitag
as code owners
|
Kudos, SonarCloud Quality Gate passed!
|
pwei1018
approved these changes
Sep 7, 2023
eve-git
approved these changes
Sep 7, 2023
bolyachevets
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*Issue #, if available: entity/issues/17411
Description of changes:
Looks like this was caused by #1254 that was addressing bcgov/entity#12596
I added to check that a REAPPLY transaction that falls within the correct timeframe is allowed to proceed
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namex license (Apache 2.0).