Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Society NR - wrong designation error message #17442

Closed
Mihai-QuickSilverDev opened this issue Aug 21, 2023 · 3 comments
Closed

New Society NR - wrong designation error message #17442

Mihai-QuickSilverDev opened this issue Aug 21, 2023 · 3 comments
Assignees
Labels
bug Something isn't working ENTITY Business Team Priority2

Comments

@Mihai-QuickSilverDev
Copy link
Collaborator

Mihai-QuickSilverDev commented Aug 21, 2023

The explanatory text should read Societies, not Cooperatives. "A Society name must include....."
Steps to replicate this issue:

  1. Start a Society NR
  2. Enter a name that does not contain a required societies related designation
  3. Submit your NR
  4. Observe the described error

Private Zenhub Image

@Mihai-QuickSilverDev Mihai-QuickSilverDev added ENTITY Business Team bug Something isn't working labels Aug 21, 2023
@severinbeauvais
Copy link
Collaborator

It appears that Namex API is returning the wrong error code (DESIGNATIONS_MISSING_CP or DESIGNATIONS_CHECK_USE_CP), and the UI doesn't have an appropriate message for Societies.

I believe this fix will require a Namex API change + a Namerequest UI change.

@severinbeauvais severinbeauvais changed the title New Society NR - Wrong Description New Society NR - wrong designation error message Aug 31, 2023
@severinbeauvais
Copy link
Collaborator

Hi Eve. Per @davemck513 , are you able to work on this ticket in this sprint?

@eve-git
Copy link
Collaborator

eve-git commented Sep 6, 2023

Code has been merged and ready for test @ https://namerequest-dev--pr-670-2i0gly5a.web.app/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ENTITY Business Team Priority2
Projects
None yet
Development

No branches or pull requests

4 participants