Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Societies NR flows #17206

Closed
5 tasks done
severinbeauvais opened this issue Jul 26, 2023 · 12 comments
Closed
5 tasks done

Implement Societies NR flows #17206

severinbeauvais opened this issue Jul 26, 2023 · 12 comments
Assignees
Labels

Comments

@severinbeauvais
Copy link
Collaborator

severinbeauvais commented Jul 26, 2023

Uxpin diagram: https://preview.uxpin.com/a86dccdd20ac62828f965c5eea10f81b828a9853#/pages/163039780/comment/no-panels/64c158baa1672e14cc5724cd

  • Add FF to hide dialog / enable new flow? YES
    • in case Societies NR needs to be released AFTER the way of navigating changes (feature branch)
  • Verify whether Societies flows (new, change, etc) work in UI (*).
    • Namex API may need some work -- identify this and raise it with Patrick/Omid
  • Do Societies have a designation?
    • no but there are name rules -- see next bullet
  • Implement name rules on second page (see comments below).
  • When NR is approved, on Existing NR page, show link button to Societies Online instead of "Incorporate Now". See https://preview.uxpin.com/a86dccdd20ac62828f965c5eea10f81b828a9853#/pages/163953828/simulate/sitemap

(*) Here are the subject NR Request Type codes (link):

  SO = 'SO', // new SOCIETY
  ASO = 'ASO', // amlagamate SOCIETY
  CSO = 'CSO', // change SOCIETY
  RSO = 'RSO', // restoration SOCIETY
  CTSO = 'CTSO', // move SOCIETY - Society - Continuation In <<< see blocked ticket and add missing code
  CSSO = 'CSSO', // convert SOCIETY - Society - Conversion of a Special Act <<< will be handled by future flow ticket

This ticket supersedes ticket 16845 in SRE team space.

@severinbeauvais severinbeauvais added the ENTITY Business Team label Jul 26, 2023
@severinbeauvais
Copy link
Collaborator Author

@pwei1018 @ozamani9gh @eve-git FYI.

@severinbeauvais
Copy link
Collaborator Author

@jdyck-fw @davemck513 Should we put this ticket in our current sprint?

@severinbeauvais
Copy link
Collaborator Author

@janisrogers Roll-up of questions for you, please and thanks :)

  1. Verify new Societies flow documented in uxpin above against currrent name request flow in Societies Online (chat with Oge). Update uxpin if needed.
  2. Spec out what the link to Societies Online (on existing NR page) should look line (and possibly the gray box blurb?).
  3. When does the societies NR change become effective -- at the same time as the other "navigating" changes, or later? If later then we will need a FF to enable it.
  4. Do societies have a designation?

@janisrogers
Copy link
Collaborator

@severinbeauvais

  1. I won't have a chance to look at this this week, but I don't think the designs will be vastly different. A design ticket should be created, but off the top of my head, they would look like Coops. (no numbered, no designation). The hover text (on business type) will need to be updated and it will need to follow the flow instead of having a popup when Society is selected as business type.
  2. This has already been done for the results page
    image
  3. Conversations with Patrick are needed to determine this, but if they release before us there would be a bunch of code thrown out for the first page, so in my opinion it should be coordinated to go with our release.
  4. No, societies don't have a designation like the others with a dropdown, they have rules like Coops where certain words have to be contained in their name, but not at the end of the name. These rules will (I assume) be handled on the second page like they are for Coops.

Usually have one of the following as part of the name:
Association, ASSN. or Assn.
Chamber of Commerce
Church or Eglise
Club
Christian School
Fellowship
Foundation or Fondation
Guild
Parish
Society or Societe
Watershed

@severinbeauvais
Copy link
Collaborator Author

severinbeauvais commented Aug 2, 2023

Thanks, Janis.

@pwei1018 , can you confirm when Societies NR can be released in Prod -- end Aug to mid Sept? If so then we don't need a FF. If later then we do.

Also, can someone confirm the name rules? This is a requirement I didn't know until now and it increases the effort to implement this. cc: @davemck513

@janisrogers
Copy link
Collaborator

@severinbeauvais The name rules for societies will not be implemented on the first page. I assume this is work that Patrick will be doing.

@severinbeauvais
Copy link
Collaborator Author

We have Eve, from Patrick's team, currently on the Entities Team and working on this right now.

We're talking about the same name rules, right?

These rules will (I assume) be handled on the second page like they are for Coops.

I think these will need to be implemented as part of THIS ticket so that users don't create invalid Societies NRs. Actually these checks may exist in the Namex API, not the UI, and may need to be added there. @eve-git FYI

@janisrogers
Copy link
Collaborator

Namex already deals with Societies names. What needs to be updated as part of Patrick's project is the second page of Name Request that checks if the person's name matches the various rules, then gives guidance to the user.

@severinbeauvais
Copy link
Collaborator Author

I think those rules are implemented in the API not in the UI. They may already exist there, I don't know.

And implementing those, if needed, is part of this ticket, so we need to define/confirm those requirements here, if only for testing purposes.

@eve-git
Copy link
Collaborator

eve-git commented Aug 17, 2023

Deploy:
A new feature flag to be added: enable-society

Ready to test:
Temporary Url for review: https://namerequest-dev--pr-651-dk4f535f.web.app
The validation of BC corp number is not included in the change

@severinbeauvais severinbeauvais removed the SRE SRE team task label Aug 30, 2023
@janisrogers
Copy link
Collaborator

@Mihai-QuickSilverDev Can you include the requirements for Society name designations in this ticket? I think Oge did the requirements.

@severinbeauvais
Copy link
Collaborator Author

^^ If anything needs to be updated, we could do it in #17442.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants