-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
17206 implement society NR flows #651
17206 implement society NR flows #651
Conversation
], | ||
REH: [ | ||
EntityType.CR, | ||
EntityType.CP, | ||
EntityType.CC, | ||
EntityType.UL, | ||
EntityType.FI, | ||
EntityType.BC | ||
EntityType.BC, | ||
EntityType.SO | ||
], | ||
CHG: entityTypesBC.filter(ent => ent !== EntityType.PAR && ent !== EntityType.PA), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any change needed for CHG? (I see PAR in there, which is a designation....?
Why is SO already part of MVE list?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I am not familiar with this part. It is old code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you test around this code to see what it might do and whether it works correctly? Ask Mihai for help if needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very good and clean. Nice! Please see my small comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but please get another review or 2.
@@ -103,6 +103,11 @@ export class CommonMixin extends Vue { | |||
return supportedEntites.includes(nr?.entity_type_cd) | |||
} | |||
|
|||
/** in case Societies NR needs to be released AFTER the way of navigating changes (feature branch) */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great Eve! 👍
/gcbrun |
Temporary Url for review: https://namerequest-dev--pr-651-dk4f535f.web.app |
@severinbeauvais I've unit tested. @pwei1018 provided a temporary url for review. Does it mean the code merge will be applied after it has been tested? |
devops/vaults.env
Outdated
@@ -10,6 +10,7 @@ VUE_APP_DASHBOARD_URL="op://web-url/$APP_ENV/business/DASHBOARD_URL" | |||
VUE_APP_ENTITY_SELECTOR_URL="op://web-url/$APP_ENV/entity-selector/ENTITY_SELECTOR_URL" | |||
VUE_APP_PAYMENT_PORTAL_URL="op://web-url/$APP_ENV/pay/PAYMENT_PORTAL_URL" | |||
VUE_APP_SITEMINDER_LOGOUT_URL="op://web-url/$APP_ENV/siteminder/SITEMINDER_LOGOUT_URL" | |||
VUE_APP_SOCIETIES_ONLINE_HOME_URL="op://web-url/$APP_ENV/bcregistry/SOCIETIES_URL/" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to remove the '/' at the end of string.
Eve, the temporary URL is automatically generated after anyone commenting |
@JazzarKarim please commit /gcbrun again because I have a new commit. Thanks. |
Temporary Url for review: https://namerequest-dev--pr-651-dk4f535f.web.app |
Sorry Eve, I just saw this. Sure thing! Btw, you can also run the command yourself like just what happened 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍
Karim may have answered this... The PR temporary URL allows preliminary testing before the PR is merged. If you're asking about the feature branch -- we will need a PR to merge the feature branch into main, once everything is complete. Ask again if you still have questions. |
* implement society NR flows * implement society * update version * according to code review * according to code review * according to code review * FF enable-society value is disabled * according to code review * remove '/' from url
* implement society NR flows * implement society * update version * according to code review * according to code review * according to code review * FF enable-society value is disabled * according to code review * remove '/' from url
* implement society NR flows * implement society * update version * according to code review * according to code review * according to code review * FF enable-society value is disabled * according to code review * remove '/' from url
* implement society NR flows * implement society * update version * according to code review * according to code review * according to code review * FF enable-society value is disabled * according to code review * remove '/' from url
* implement society NR flows * implement society * update version * according to code review * according to code review * according to code review * FF enable-society value is disabled * according to code review * remove '/' from url
Issue #: /bcgov/entity#17206
Description of changes:
implement society NR flows.
new environment variable: VUE_APP_SOCIETIES_ONLINE_HOME_URL="https://dev.bcregistry.ca/societies/"
new feature flag: enable-society
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namerequest license (Apache 2.0).