Namerequest UI: "isAuthenticated" is not refreshed on login

[severinbeauvais]

This issue was found in #18023, in which the logged-in breadcrumb was not being displayed until the app is reloaded.

1. don't be logged in
2. go to Namerequest UI
3. observe the non-logged in breadcrumb:

Private Zenhub Image

4. log in
5. observe that the incorrect breadcrumb is displayed (same as above)
6. reload the page (F5)
7. observe that the correct logged-in breadcrumb is displayed:

Private Zenhub Image

Analysis

isAuthenticated is a store getter that checks the existence of a Keycloak token in session storage. However, the KC token is not populated until a few seconds after the user logs in (it's async in the SbcHeader component), and isAuthenticated is not responsive to it because it's in session storage. Bottom line: isAuthenticated does not get updated after a successful login.

The impact is that any code that checks if the user is logged in will not work correctly. This bug has existed since NR UI was first implemented, but now it's visible in the breadcrumb (which itself is low severity).

This only happens if the user goes to NR UI while logged out and then logs in. If the user is already logged in and goes to NR UI then this bug doesn't manifest.

[Mihai-QuickSilverDev]

@ozamani9gh Something for your consideration.

[severinbeauvais]

I have a couple of proper technical solutions to propose, which I will document here when I have a moment. done, see below

[severinbeauvais]

Proposed solution # 1 (simplest)

Use a store variable to maintain the "is authenticated" state. Update it when the app starts (in App.vue::created()) and when login has completed (in Signin.vue::onReady()).

Sample code change: bcgov/namerequest#726.

Proposed solution # 2

Wait for current account to be available, as is done here: https://github.com/bcgov/business-edit-ui/blob/05d30b4c5a59ad29050bf27b52573f6a3c74cbac/src/App.vue#L557

Proposed solution # 3 (best)

Link to the auth store and read its state directly, as is done here: https://github.com/bcgov/business-filings-ui/blob/23ee32c04343d48ca84161843e8bb10a5eab9f90/src/stores/authenticationStore.ts#L25

[ozamani9gh]

@Mihai-QuickSilverDev @severinbeauvais are you hoping Names Team picks up this work. If so:

Does this need to be groomed, worked on as part of WoN Release, or can we start this after the implementation. our team is at velocity this sprint, so I would need to move priorities around

[severinbeauvais]

This bug has been around for years and I think very few users will bump into it, so it's not P1 and can be fixed later (IMHO).

[Mihai-QuickSilverDev]

@ozamani9gh Hi Omid, yes, this is a Names ticket, and would leave it to you to schedule. It can be done after the WoN go-live on October 17.

[eve-git]

PR: bcgov/namerequest#742

[eve-git]

Ready to test in DEV and TEST environments.

[oanyahuru]

I tested it and the correct breadcrumb displayed when I logged in..
Private Zenhub Image